Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a few issues with the title editor #3727

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

jonoomph
Copy link
Member

  1. font-size was not being initialized on the font dialog, and
  2. font-size was not being set (even though it can clobber our template settings
  3. Not all text colors were being found when loading an SVG and setting the 'text-color' button

Overall, this fixes some of the broken behavior, but there are still a few outstanding issues with the title editor. Not all fonts are rendered on Windows for starters, often, it falls back to a default font. Not sure if this is caused by resvg, but seems likely.

… initialized on the font dialog, and 2) font-size was not being set (even though it can clobber our template settings 3) Not all text colors were being found when loading an SVG and setting the 'text-color' button.
@jonoomph jonoomph merged commit 3969f56 into develop Sep 18, 2020
@jonoomph jonoomph deleted the fix-font-dialog branch September 18, 2020 22:35
@jonoomph
Copy link
Member Author

Merging to do some daily build testing with a couple users

@ferdnyc
Copy link
Contributor

ferdnyc commented Sep 20, 2020

Not sure if this is caused by resvg, but seems likely.

See linebender/resvg#297.

@ferdnyc
Copy link
Contributor

ferdnyc commented Oct 26, 2020

@jonoomph

Since this change, I'm getting a ton of this when running with --debug:

DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to delete child settings widget
DEBUG title_editor: Failed to parse fill:#324da7 as opacity value
DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to parse fill:#324da7 as opacity value
DEBUG title_editor: Failed to parse fill:#6f82c1 as opacity value
DEBUG title_editor: Failed to delete child settings widget
DEBUG title_editor: Failed to parse fill:url(#radialGradient3654) as opacity value
DEBUG title_editor: Failed to parse fill:url(#radialGradient3654) as opacity value
DEBUG title_editor: Failed to delete child settings widget
DEBUG title_editor: Failed to parse fill:#ffffff as opacity value
DEBUG title_editor: Failed to parse fill:#ffffff as opacity value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants