Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blender: Protect embedded params #3763

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Blender: Protect embedded params #3763

merged 1 commit into from
Oct 15, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Oct 15, 2020

  • To protect backslash escapes, the JSON-serialized Blender parameters need to be embedded as a raw string literal in the Python script
  • Fix bad signal emitted by worker
  • Dump full Blender output to log on failure, always (not just when debugging)
  • Try a bit harder to ensure we clear override cursors when Blender crashes

Fixes #3759, fixes #3762

@ferdnyc
Blender: Protect embedded params
1759c79 
- To protect backslash escapes, the JSON-serialized Blender parameters
  need to be embedded as a raw string literal _in_ the Python script
- Fix bad signal emitted by worker
- Dump full Blender output to log on failure, always (not just when
  debugging)
- Try a bit harder to ensure we clear override cursors when Blender
  crashes
@ferdnyc ferdnyc mentioned this pull request Oct 15, 2020
Closed
@ferdnyc ferdnyc added the closer This PR fixes one or more reported Issues label Oct 15, 2020
@ferdnyc ferdnyc merged commit 7f96b0b into OpenShot:develop Oct 15, 2020
@ferdnyc ferdnyc deleted the blender-rendering branch October 15, 2020 09:48
@jonoomph
Copy link
Member

LGTM!

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Oct 20, 2020

@jonoomph Took me three tries (#3761, #3749), but I get there eventually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closer This PR fixes one or more reported Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title animated. After rendering it crashes and does't save Animated Titles not working in latest Daily Build
2 participants
@ferdnyc @jonoomph