Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change I left out of #3684 — MainWindow (and really all Qt-based classes) needs to have its Qt parent listed last in its parent class list, so that it will be the first lookup for all inherited members.
IOW,
Doesn't guarantee that
super()
calls will always go to the correspondingQMainWindow
class members (if they're present). But,does.
This especially matters for things like
__init__
that lots of classes share, but AIUI it's also a good idea in general. Python's multiple-inheritance implementation received two massive overhauls back in the Python 3.2 - 3.4 dev cycles, before reaching its current form, and it can still be a bit shaky at times apparently.