Fix middle click drag, and ruler jitter #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, other than Codacy issues. Also, let's update the description on this one, and make sure we give enough context into what has been fixed. 👍 |
|
Merge away! 🙏 Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed here:
Middle click drag was sending the timeline to 00:00:00,0. I made some changes so that it works relative to the timeline's original position.
The ruler draws a time on every other mark. As you scroll left, it was always starting with the second mark on screen, breaking up the continuous motion of the ruler. I made sure that the ruler always draws times on the same marks, so the scrolling feels continuous.
If you resized the timeline in some way, the ruler wasn't redrawing until you scrolled or zoomed. I added
element.width()to the watched variables that callsdrawRuler, so that this now causes the ruler to redraw.