Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry & Metric Improvements #4322

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Sentry & Metric Improvements #4322

merged 5 commits into from
Aug 19, 2021

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Aug 19, 2021

Improving Sentry.io error reporting to dynamically set the error rate, based on rates obtained from openshot.org when retrieving the current version info. This helps us adjust this rate as a release matures, and no longer needs to send in as many error reports... but initially, right after a release, we can turn up the dial, and receive more reports. Also, I've optimized the metric tracking to always report the initial launch (only on 1st install), and then opt the user out (and prompt the user to opt back in for all subsequent metric tracking). This is essentially the same as before, except we will get accurate anonymous metrics on how many downloads/installs of OpenShot are happening.

Fixed some issues with the Tutorial dock, which does not always position itself correctly. Also, changed the default simple view of OpenShot, to place the Emojis dock in tabbed mode: Files, Transitions, Effects, Emojis. Lastly, fixed the exit of OpenShot to not hang on our thumbnail server and ZMQ polling.

…e can adjust them dynamically (stable vs unstable versions).
…leaving the tutorial window in the upper right corner)
…l launch anonymously, and then opt-out the user and prompt them to opt back in. Essentially this is the same as before, except we get the initial launch analytic (to help us better report on our usage and market share). All subsequent tracking is disabled until the user opts in.
…self... so we don't get stuck on program exit waiting forever for a ZMQ polling event.
@jonoomph
Copy link
Member Author

Merging

@jonoomph jonoomph merged commit 6bc4d9f into develop Aug 19, 2021
@jonoomph jonoomph deleted the sentry-improvements branch August 19, 2021 16:32
Copy link
Collaborator

@JacksonRG JacksonRG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple questions for understanding.

src/classes/sentry.py Show resolved Hide resolved
src/settings/_default.settings Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants