repair project files with invalid json for paths #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 27, 2021
JacksonRG
force-pushed
the
repair-project-files
branch
from
6105661
to
09951ec
Compare
jonoomph
reviewed
Aug 28, 2021
…compiling regex, and updating original file during the project open.
JacksonRG
commented
Aug 28, 2021
|
LGTM! Merge away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4211 caused a specific case where a user's osp would be written without valid json. (No quotes on the key for a path attribute)
This is meant to find any such errors in a project file, and fix them before attempting to open.