Support for New Linux Build Server + Update AppImage Support #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cting with FFmpeg4
…cting with FFmpeg4
…er distros) - requires openshot to be imported first
jonoomph
commented
Nov 29, 2022
| @@ -1,30 +1,5 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Query the current display DPI | |||
There was a problem hiding this comment.
High DPI is now supported by default in the AppImage format
jonoomph
commented
Nov 29, 2022
| os.chmod(launcher_path, st.st_mode | stat.S_IEXEC) | ||
|
|
||
| # Create AppImage (OpenShot-%s-x86_64.AppImage) | ||
| app_image_success = False | ||
| for line in run_command(" ".join([ | ||
| '/home/ubuntu/apps/AppImageKit/AppImageAssistant', | ||
| '/home/ubuntu/apps/AppImageKit/appimagetool-x86_64.AppImage', |
There was a problem hiding this comment.
Updating from very old AppImage creation process to latest / best practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: OpenShot/libopenshot-audio#146 and OpenShot/libopenshot#878
Adding support for a new Linux build server (Ubuntu 20.04), which has updated dependencies, but also a newer glibc version. This only affects our AppImage builds.
Pros:
Cons: