Windows Installer (AppID + App DisplayName) #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… previous releases
… previous releases
…hes previous releases
… (experimental) - take 2
… (experimental) - take 3
… uninstall screens
jonoomph
commented
Dec 8, 2022
| @@ -24,9 +24,10 @@ | |||
| ; NOTE: The value of AppId uniquely identifies this application. | |||
| ; Do not use the same AppId value in installers for other applications. | |||
| ; (To generate a new GUID, click Tools | Generate GUID inside the IDE.) | |||
| AppId={code:GetAppId|4BB0DCDC-BC24-49EC-8937-72956C33A470} | |||
| AppId={code:GetAppId|{{4BB0DCDC-BC24-49EC-8937-72956C33A470}} | |||
jonoomph
commented
Dec 8, 2022
| AppName=OpenShot Video Editor | ||
| AppVersion={#VERSION} | ||
| AppVerName={#MyAppName} {#VERSION} |
There was a problem hiding this comment.
This updates the name of OpenShot displayed in the installer and Add/Remove Programs screens. "OpenShot Video Editor 3.0.0" for example.
jonoomph
commented
Dec 8, 2022
| @@ -134,6 +135,8 @@ Root: HKLM; Subkey: "Software\Classes\.osp"; ValueType: string; ValueName: ""; V | |||
| Root: HKLM; Subkey: "Software\Classes\OpenShotProject"; ValueType: string; ValueName: ""; ValueData: "{#MyAppProjectFileDesc}"; Flags: uninsdeletekey; Tasks: fileassoc | |||
| ; Launcher association for data files of type OpenShotProject | |||
| Root: HKLM; Subkey: "Software\Classes\OpenShotProject\shell\open\command"; ValueType: string; ValueName: ""; ValueData: """{app}\{#MyAppExeName}"" ""%1"""; Tasks: fileassoc | |||
| ; Clean-up old, incorrect AppID Uninstaller (used in 2.6.1-dev builds) | |||
There was a problem hiding this comment.
For a while now our daily builds have been using a different AppID key in the registry, missing { } curly brackets. This line removes this old entry from the registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix our 3.0.0 release candidate Windows installer to use the same AppID in the registry as our previous stable builds (
2.5.1,2.6.0, and2.6.1). This prevents multiple entries in theAdd / Remove Programsscreen.