Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Installer (AppID + App DisplayName) #5027

Merged
merged 9 commits into from
Dec 8, 2022
Merged

Windows Installer (AppID + App DisplayName) #5027

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ce9680
Trying to fix the Windows appID of the installer, so it matches previ…
jonoomph Dec 8, 2022
cb8afb6
Trying again to fix the Windows appID of the installer, so it matches…
jonoomph Dec 8, 2022
9873527
Trying again to fix the Windows appID of the installer, so it matches…
jonoomph Dec 8, 2022
c71ce8d
Trying 3rd time to fix the Windows appID of the installer, so it matc…
jonoomph Dec 8, 2022
42a71c7
Updating name used in Windows uninstaller
jonoomph Dec 8, 2022
817726f
Attempt to clean-up invalid uninstall AppID from previous daily build…
jonoomph Dec 8, 2022
cbc3f19
Attempt to clean-up invalid uninstall AppID from previous daily build…
jonoomph Dec 8, 2022
b715f5c
Attempt to clean-up invalid uninstall AppID from previous daily build…
jonoomph Dec 8, 2022
2d355ce
Updating AppVerName, used on welcome screen of windows installer, and…
jonoomph Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion installer/windows-installer.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@
; NOTE: The value of AppId uniquely identifies this application.
; Do not use the same AppId value in installers for other applications.
; (To generate a new GUID, click Tools | Generate GUID inside the IDE.)
AppId={code:GetAppId|4BB0DCDC-BC24-49EC-8937-72956C33A470}
AppId={code:GetAppId|{{4BB0DCDC-BC24-49EC-8937-72956C33A470}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{ is escaped to "{"

AppName=OpenShot Video Editor
AppVersion={#VERSION}
AppVerName={#MyAppName} {#VERSION}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates the name of OpenShot displayed in the installer and Add/Remove Programs screens. "OpenShot Video Editor 3.0.0" for example.

VersionInfoVersion={#VERSION}
AppPublisher={#MyAppPublisher}
AppPublisherURL={#MyPublisherURL}
Expand Down Expand Up @@ -134,6 +135,8 @@ Root: HKLM; Subkey: "Software\Classes\.osp"; ValueType: string; ValueName: ""; V
Root: HKLM; Subkey: "Software\Classes\OpenShotProject"; ValueType: string; ValueName: ""; ValueData: "{#MyAppProjectFileDesc}"; Flags: uninsdeletekey; Tasks: fileassoc
; Launcher association for data files of type OpenShotProject
Root: HKLM; Subkey: "Software\Classes\OpenShotProject\shell\open\command"; ValueType: string; ValueName: ""; ValueData: """{app}\{#MyAppExeName}"" ""%1"""; Tasks: fileassoc
; Clean-up old, incorrect AppID Uninstaller (used in 2.6.1-dev builds)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a while now our daily builds have been using a different AppID key in the registry, missing { } curly brackets. This line removes this old entry from the registry.

Root: HKLM; Subkey: "Software\Microsoft\Windows\CurrentVersion\Uninstall\4BB0DCDC-BC24-49EC-8937-72956C33A470_is1"; ValueName: ""; Flags: deletekey;

[Files]
; Add all frozen files from cx_Freeze build
Expand Down