Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facebook - User Consent Policy #613

Closed
OTA-Bot opened this issue Oct 22, 2021 · 5 comments
Closed

Add Facebook - User Consent Policy #613

OTA-Bot opened this issue Oct 22, 2021 · 5 comments
Assignees

Comments

@OTA-Bot
Copy link

OTA-Bot commented Oct 22, 2021

New service addition requested through the contribution tool

You can see the work done by the awesome contributor here:
https://opentermsarchive.org/contribute/service?documentType=User%20Consent%20Policy&name=Facebook&selectedCss[]=.pal&step=2&url=https%3A%2F%2Fwww.facebook.com%2Fabout%2Fprivacy%2Flegal_bases&expertMode=true

Or you can see the JSON generated here:

{
  "name": "Facebook",
  "documents": {
    "User Consent Policy": {
      "fetch": "https://www.facebook.com/about/privacy/legal_bases",
      "select": [
        ".pal"
      ]
    }
  }
}

You will need to create the following file in the root of the project: services/Facebook.json

@martinratinaud
Copy link
Member

Unfortunately, this new service which has been added here 758005a

cause sometimes a scraping error with the following

This page isn't available in your location

We need to have a new approach for that which could be

  • a declaration of a proxy to bypass this limitation ({ proxy: "FR"} for example, that would try to fetch through a french proxy)
  • to ALWAYS use a proxy, so that we know where we're out from

@MattiSG @Ndpnt any idea?

1 similar comment
@martinratinaud
Copy link
Member

Unfortunately, this new service which has been added here 758005a

cause sometimes a scraping error with the following

This page isn't available in your location

We need to have a new approach for that which could be

  • a declaration of a proxy to bypass this limitation ({ proxy: "FR"} for example, that would try to fetch through a french proxy)
  • to ALWAYS use a proxy, so that we know where we're out from

@MattiSG @Ndpnt any idea?

@MattiSG
Copy link
Member

MattiSG commented Oct 27, 2021

This relates to #166 and #316 and concerns the topic of circumvention of automated blocks, with the added twist that adding a proxy would also decrease geolocation variability. This discussion is a wider one than this specific document.

This specific document seems to not be available in several jurisdictions. Could I ask where you found it from? 🙂 The commit you referenced has no specific description and has a warning saying “This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.”, so I cannot easily understand its origin.

@martinratinaud
Copy link
Member

Well, I do not know who contributed :-)
We would need to address this point ASAP also because it's really too bad that the contributor is unknown.

The commit is not in any branch anymore because I removed it to be able to merge the PR.
If you want to test on local, you can copy and paste its content in the Facebook.json file

@MattiSG
Copy link
Member

MattiSG commented Nov 2, 2021

The commit is not in any branch anymore because I removed it to be able to merge the PR.

I am not sure to fully understand: does that mean the document is not tracked at all in the end? I understand that this document is indeed not tracked at the moment. There are two commits that added it and were apparently merged directly to master: d5250e5 and 758005a. Neither are to be found in the tree now. It is hard for me to follow through the changes when they are pushed directly without a PR.

From what I understand:

  1. This document fails.
  2. We have no way to contact the contributor that suggested adding it.
  3. This document is not currently tracked.

If all of that is correct, I consider the relevant course of action to be to close this issue. I will go forth and close it. Please reopen it if I got something wrong 🙂

@MattiSG MattiSG closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants