Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON inspector editable #61

Open
timlehr opened this issue Sep 20, 2024 · 3 comments
Open

Make JSON inspector editable #61

timlehr opened this issue Sep 20, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@timlehr
Copy link
Collaborator

timlehr commented Sep 20, 2024

Feature suggestion
Currently the JSON editor is read-only. Making it editable would let us explore & understand how changes affect the composition.

@reinecke reinecke added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 20, 2024
@vfleuryrodeofx
Copy link

I'll try and take a look at this feature for Dev days :)

@vfleuryrodeofx
Copy link

Hey !
Just a quick follow-up to mention that I took a look at that but unfortunately I think it was beyond my C++ abilities.
I managed to get the editor to be editable by modifying this line https://github.com/OpenTimelineIO/raven/blob/main/inspector.cpp#L75
But I did not go further than that to hook modifications made in the editor to reflect in the current loaded timeline.
If anyone else want to take it up, go for it !

@jminor
Copy link
Member

jminor commented Oct 7, 2024

Thanks for giving it a try @vfleuryrodeofx !

A note for anyone else attempting this in the future: I suspect this feature would require noticing edits to the text via some callback in the text editor widget, then deleting the selected item and replacing it with a freshly deserialized object from the edited JSON text. It would also need to be defensive about invalid JSON introduced by typos.

@jminor jminor removed the good first issue Good for newcomers label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants