-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul style and formatting #305
base: master
Are you sure you want to change the base?
Conversation
21d80b4
to
47725ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of good catches here, particularly spelling mistakes, but in many places clang-format is still very messy and inconsistent IMO, especially with newlines and indentation. If we can find settings that address these issues that would be great, but in its current state I find it makes the code harder to read overall and I wouldn't want it applied everywhere automatically.
Thinking about it some more, if we could disable it from doing anything about indentation/newlines (particularly in relation to brackets) that would solve most of its problems. Most formatting issues I see in PRs are to do with stuff like missing single spaces while indentation tends to be good (as it's far more obvious when it's badly wrong).
extension/src/openvic-extension/classes/GFXButtonStateTexture.cpp
Outdated
Show resolved
Hide resolved
extension/src/openvic-extension/classes/GFXButtonStateTexture.cpp
Outdated
Show resolved
Hide resolved
extension/src/openvic-extension/classes/GFXButtonStateTexture.cpp
Outdated
Show resolved
Hide resolved
extension/src/openvic-extension/classes/GFXButtonStateTexture.cpp
Outdated
Show resolved
Hide resolved
extension/src/openvic-extension/classes/GFXMaskedFlagTexture.cpp
Outdated
Show resolved
Hide resolved
extension/src/openvic-extension/classes/GUIOverlappingElementsBox.cpp
Outdated
Show resolved
Hide resolved
05ec7f5
to
7915022
Compare
Add pre-commit configuration file Organize and overhaul .clang-format Add codespell checks and corrections
7915022
to
221f293
Compare
Add pre-commit configuration file
Organize and overhaul .clang-format
Add codespell checks and corrections