Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul style and formatting #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Spartan322
Copy link
Member

Add pre-commit configuration file
Organize and overhaul .clang-format
Add codespell checks and corrections

@Spartan322 Spartan322 added enhancement New feature or request meta labels Nov 27, 2024
@Spartan322 Spartan322 force-pushed the format-overhaul branch 2 times, most recently from 21d80b4 to 47725ea Compare November 27, 2024 06:11
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of good catches here, particularly spelling mistakes, but in many places clang-format is still very messy and inconsistent IMO, especially with newlines and indentation. If we can find settings that address these issues that would be great, but in its current state I find it makes the code harder to read overall and I wouldn't want it applied everywhere automatically.

Thinking about it some more, if we could disable it from doing anything about indentation/newlines (particularly in relation to brackets) that would solve most of its problems. Most formatting issues I see in PRs are to do with stuff like missing single spaces while indentation tends to be good (as it's far more obvious when it's badly wrong).

extension/src/openvic-extension/classes/GUILabel.cpp Outdated Show resolved Hide resolved
extension/src/openvic-extension/classes/GUIScrollbar.cpp Outdated Show resolved Hide resolved
@Spartan322 Spartan322 force-pushed the format-overhaul branch 13 times, most recently from 05ec7f5 to 7915022 Compare November 28, 2024 03:18
Add pre-commit configuration file
Organize and overhaul .clang-format
Add codespell checks and corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants