Skip to content

Conversation

@NeonJarbas
Copy link

fix issue introduced in #32 , reported in NeonGeckoCom/NeonCore#243

get_response was reporting that converse was not implemented / skill did not want to converse

@JarbasAl JarbasAl added bug Something isn't working bug-ovos labels May 22, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel May 22, 2022 17:06
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #124 (9a9a485) into dev (6ceb058) will increase coverage by 2.97%.
The diff coverage is 34.93%.

@@            Coverage Diff             @@
##              dev     #124      +/-   ##
==========================================
+ Coverage   50.35%   53.33%   +2.97%     
==========================================
  Files         119      149      +30     
  Lines       10077     9068    -1009     
==========================================
- Hits         5074     4836     -238     
+ Misses       5003     4232     -771     
Impacted Files Coverage Δ
mycroft/api/__init__.py 30.24% <0.00%> (-47.99%) ⬇️
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6082802...9a9a485. Read the comment docs.

@JarbasAl JarbasAl merged commit 1051c13 into OpenVoiceOS:dev May 22, 2022
@NeonJarbas NeonJarbas deleted the fix/converse branch June 8, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants