forked from MycroftAI/mycroft-core
-
-
Notifications
You must be signed in to change notification settings - Fork 28
Port mk2 GUI service with additional improvements to core #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Additionally Added Improvements:
|
Member
Codecov Report
@@ Coverage Diff @@
## dev #66 +/- ##
==========================================
+ Coverage 47.53% 49.08% +1.55%
==========================================
Files 112 115 +3
Lines 9474 9720 +246
==========================================
+ Hits 4503 4771 +268
+ Misses 4971 4949 -22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports Mark-2/QA branch GUI service and namespace API improvements to ovos-core
Additional Changes (These were required to make the API work as designed and not loose functionality):
Added Homescreen Manager: The Homescreen manager service allows for adding, removing, switching and disabling multiple homescreen installations
Improvements to the IdleDisplaySkill class to register idle skills on initialize, homescreen manager events, handling reload of skill, handling shutdown of skill
Added Fix For Page Insertion as per Mycroft-GUI Protocol: Mark-2/QA branch seems to somehow discard the protocol requirement (maybe a bug or oversight) and adds all additional pages at index 0 in "mycroft.gui.list.insert", In this PR it is fixed to always account for the position at which the page was inserted as maintained in the namespace pages list
Added Fix For Checking persistence and resetting timeout removal of namespace when user interacts with the page on the screen for a given namespace.
Added Fix For Updating persistence when a persistent page is added to the namespace after a non persistent page, this fixes the issue where all pages are removed and each page persistence is not accounted for
Increased the default timeout by default to 30 seconds as it was set to originally, the mark-2/qa branch sets it to 15 seconds, which does not give enough time for skills wanting to be interacted with or displaying more than one page