Add robust subscription #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: remove comment
LeoPatOZ
commented
Nov 11, 2025
LeoPatOZ
force-pushed
the
add-robust-subscription
branch
from
efd857d to
e6b1455
Compare
ref: better comments fix: remove bracket
LeoPatOZ
force-pushed
the
add-robust-subscription
branch
from
e6b1455 to
71a3b3b
Compare
0xNeshi
reviewed
Nov 13, 2025
0xNeshi
reviewed
Nov 13, 2025
0xNeshi
reviewed
Nov 13, 2025
Comment on lines
+511
to
+512
| let block = stream.next().await.unwrap()?; | ||
| assert_eq!(1, block.number()); |
Collaborator
There was a problem hiding this comment.
nit: can't use assert_next!?
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_robust_subscription_stream_with_failover() -> anyhow::Result<()> { |
Collaborator
There was a problem hiding this comment.
We need a test case that shows that the scanner occasionally tries the primary provider.
Maybe something like:
- Spawn
anvil_1 - Connect
provider_1 - Store
anvil_1.port()in a local variableanvil_1_port - Spawn
anvil_2 - Connect
provider_2 - Mint block on
anvil_1, assert - Drop
anvil_1 - Mint block on
anvil_2, assert stream still works - Spawn new
anvil_3with.port(anvil_1_port)<- this will ensureprovider_1ws_endpoint_url is again valid - ???
- Verify that scanner switches back to
provider_1
0xNeshi
reviewed
Nov 13, 2025
| Ok(()) | ||
| } | ||
|
|
||
| #[tokio::test] |
Collaborator
There was a problem hiding this comment.
- Add test with multiple pubsub fallbacks, where each works but then stops, to confirm scanner goes through all of them in turn.
- Add subscribe test with no fallbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167
(and hopefully #170)