Address feedback for Account #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericglau
approved these changes
Apr 23, 2025
Member
ericglau
left a comment
ericglau
left a comment
There was a problem hiding this comment.
LGTM, thanks!
To fix the tests, please update snapshots by running yarn test:update-snapshots from packages/core/solidity
Member
Author
|
Just found out that the Wizard was producing a combination that doesn't compile with an "impossible linearization" error. I'm updating and fixing the tests too |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just fixing a couple of nits:
false, which affects the discoverability of the "Signers" menu