Add _disableInitializer to Accounts constructor #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoveMB
reviewed
Jun 12, 2025
CoveMB
approved these changes
Jun 12, 2025
Member
Author
|
Before merging, let @Amxx validate whether this makes sense, or if we should approach it differently. Imo there's no rush |
ericglau
requested changes
Jun 12, 2025
ericglau
approved these changes
Jun 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables initialization on the account implementation. Post
SELFDESTRUCTremoval the only thing I think it enables would be to take funds sent to the implementation by mistake. I think it should be the default