Allow owner to see token balance of vesting wallet #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for confidential-tokens ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
arr00
reviewed
Jul 30, 2025
| * @dev Getter to retrieve the token balance of this vesting wallet. | ||
| * It allows the owner of this vesting wallet to see the confidential balance. | ||
| */ | ||
| function confidentialBalance(address token) public virtual returns (euint64 balance) { |
Contributor
There was a problem hiding this comment.
Suggested change
| function confidentialBalance(address token) public virtual returns (euint64 balance) { | |
| function allowConfidentialBalance(address token) public virtual returns (euint64 balance) { |
Contributor
Author
There was a problem hiding this comment.
It looks the discussion is kind of the same here https://github.com/OpenZeppelin/openzeppelin-confidential-contracts/pull/130/files#r2245937620:
"[...] why not introducing new public functions & instead updating existing functions?"
Contributor
james-toussaint
deleted the
bugfix/allow-owner-token-balance-of-vesting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.