Use symlinks to vanilla when possible #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for confidential-tokens ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Amxx
reviewed
Jun 17, 2025
| import { setCode } from "@nomicfoundation/hardhat-network-helpers"; | ||
| import { ethers } from "ethers"; | ||
| import { task } from "hardhat/config"; | ||
| import { impersonate } from '../test/helpers/accounts'; |
Contributor
There was a problem hiding this comment.
that could be imported from @openzeppelin/contracts/test/helpers
Contributor
Author
There was a problem hiding this comment.
There is an added function for this repo.
openzeppelin-confidential-contracts/test/helpers/accounts.ts
Lines 15 to 22 in d442fb1
Amxx
reviewed
Jun 17, 2025
Amxx
reviewed
Jun 17, 2025
| import { ACL_ADDRESS, GATEWAYCONTRACT_ADDRESS, KMSVERIFIER_ADDRESS, PRIVATE_KEY_KMS_SIGNER } from "./constants"; | ||
| import { awaitCoprocessor, getClearText } from "./coprocessorUtils"; | ||
| import { waitNBlocks } from "./utils"; | ||
| import { impersonate } from '../helpers/accounts'; |
Contributor
There was a problem hiding this comment.
some comment: can import from @openzeppelin/contracts/test/helpers
Amxx
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vanilla as a submodule and use symlinks to files to avoid code duplication. Inherit styling and rules from vanilla.