Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate MerkleProof tests among other testing utilities #4689

Merged
merged 18 commits into from
Oct 23, 2023
Merged

Migrate MerkleProof tests among other testing utilities #4689

merged 18 commits into from
Oct 23, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 17, 2023 •
edited
Loading

Helpers migrated:

  • chainId
  • constants
  • create (removed)
  • eip721
  • erc1967
  • methods
  • time (partial)

Test migrated:

  • MekleProof

Dependencies:

  • merkletreejs → @openzeppelin/merkle-tree
  • keccak256 → ethers

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c823e22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@openzeppelin/merkle-tree 1.0.5 None +0 57.3 kB frangio

🚮 Removed packages: keccak256@1.0.6, merkletreejs@0.2.32

@Amxx Amxx requested a review from ernestognw October 17, 2023 13:08
@Amxx Amxx mentioned this pull request Oct 17, 2023
Closed
ernestognw
ernestognw approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/helpers/erc1967.js
}

function getSlot(address, slot) {
return getStorageAt(
web3.utils.isAddress(address) ? address : address.address,
web3.utils.isHex(slot) ? slot : labelToSlot(slot),
ethers.isAddress(address) ? address : address.address,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we attempt supporting also address.target?

@ernestognw ernestognw mentioned this pull request Oct 20, 2023
Merged
3 tasks
@ernestognw
Copy link
Member

The comment I left is non blocking. Merging

@ernestognw ernestognw changed the title Test migration Migrate MerkleProof tests among other testing utilities Oct 23, 2023
@ernestognw ernestognw merged commit 7c8b7a2 into OpenZeppelin:master Oct 23, 2023
14 checks passed
@ernestognw ernestognw added this to the tests migration milestone Oct 23, 2023
@Amxx Amxx deleted the test/migration/create-create2 branch October 25, 2023 14:19
ernestognw pushed a commit to ernestognw/openzeppelin-contracts that referenced this pull request Oct 26, 2023
@Amxx @ernestognw
Migrate MerkleProof tests among other testing utilities (OpenZeppel…
1672d3a 
…in#4689)
@ernestognw ernestognw mentioned this pull request Oct 29, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
tests migration
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @ernestognw