Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
AccessManager
guide #4691Add
AccessManager
guide #4691Changes from 33 commits
419fc00
4849dbb
aab6c32
03437c7
1d72816
f1c6b37
f737706
326e4f7
d0290e2
2947618
584888f
a709051
d54983c
8c79f0b
44f98c4
600cb0d
da02c39
1672d3a
bb2bcf8
5e0018f
83dafac
adc4426
1d5043d
d01776c
4b29fce
b740f76
75057a3
f86742e
abaab0d
b95cda6
647a5e8
4b96759
be6e909
de39ada
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider renaming this whole page to Access Management instead of Access Control, and then talking about AccessManager first as the recommended approach for any projects that will become complex. WDYT?
I like how "Better role management can be achieved with an xref:api:access.adoc#AccessManager[
AccessManager
] instance. Instead of managing each contract's permission separately, AccessManager stores all the permissions in a single contract, making your protocol easier to audit and maintain."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed this to Fran but he disagreed. I think the section is fine defined as "Access Control" because it refers to the broader AccessControl category in security, and I'd be worried for the SEO if we change it.
Large diffs are not rendered by default.