Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compile_force_framework: hardhat from slither config #5390

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Remove compile_force_framework: hardhat from slither config #5390

merged 2 commits into from
Dec 18, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Dec 18, 2024

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6e5513a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx
Copy link
Collaborator Author

Amxx commented Dec 18, 2024

If it's working, then there's no reason to force the usage of hardhat.

#3955 (comment)

@Amxx Amxx requested a review from ernestognw December 18, 2024 19:48
@Amxx Amxx enabled auto-merge (squash) December 18, 2024 19:48
ernestognw
ernestognw approved these changes Dec 18, 2024
View reviewed changes
.github/workflows/checks.yml
Comment on lines -123 to 122
with:
node-version: 18.15
slither-version: 0.10.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that we're getting rid of these

@Amxx Amxx merged commit b50f22d into OpenZeppelin:master Dec 18, 2024
18 checks passed
@Amxx Amxx deleted the slither/remove-compile-force-framework branch December 19, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
CI ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @ernestognw