From 778b2c49e074c2b52bd6a2b9470382e5a8c10877 Mon Sep 17 00:00:00 2001
From: Antoine Niek <antoineniek@gmail.com>
Date: Wed, 5 Feb 2025 14:51:29 -0500
Subject: [PATCH] Drop legacy targeting cache

---
 lib/core/storage.test.js | 18 ------------------
 lib/core/storage.ts      | 33 +--------------------------------
 2 files changed, 1 insertion(+), 50 deletions(-)

diff --git a/lib/core/storage.test.js b/lib/core/storage.test.js
index 0f020cc..5e2cfb8 100644
--- a/lib/core/storage.test.js
+++ b/lib/core/storage.test.js
@@ -51,22 +51,4 @@ describe("LocalStorage", () => {
     expect(store.setSite());
     expect(store.getSite()).toBeNull();
   });
-
-  test("auto fixes v1 targeting as v2 base on audience key presence", () => {
-    const store = new LocalStorage(randomConfig());
-    window.localStorage.setItem(store.targetingV1Key, JSON.stringify({ k1: ["v1"], k2: ["v2"] }));
-
-    expect(store.getTargeting()).toEqual({
-      user: [],
-      audience: [
-        { provider: "optable.co", keyspace: "k1", ids: [{ id: "v1" }], rtb_segtax: 5001 },
-        { provider: "optable.co", keyspace: "k2", ids: [{ id: "v2" }], rtb_segtax: 5001 },
-      ],
-    });
-
-    store.setTargeting({ audience: [] });
-    expect(store.getTargeting()).toEqual({
-      audience: [],
-    });
-  });
 });
diff --git a/lib/core/storage.ts b/lib/core/storage.ts
index d7356ed..e7a6b09 100644
--- a/lib/core/storage.ts
+++ b/lib/core/storage.ts
@@ -13,7 +13,6 @@ function toBinary(str: string): string {
 
 class LocalStorage {
   private passportKey: string;
-  private targetingV1Key: string;
   private targetingKey: string;
   private siteKey: string;
 
@@ -21,9 +20,6 @@ class LocalStorage {
 
   constructor(private config: ResolvedConfig) {
     const sfx = btoa(toBinary(`${this.config.host}/${this.config.site}`));
-    // Legacy targeting key
-    this.targetingV1Key = "OPTABLE_TGT_" + sfx;
-
     this.passportKey = "OPTABLE_PASS_" + sfx;
     this.targetingKey = "OPTABLE_V2_TGT_" + sfx;
     this.siteKey = "OPTABLE_SITE_" + sfx;
@@ -34,36 +30,9 @@ class LocalStorage {
     return this.storage.getItem(this.passportKey);
   }
 
-  getV1Targeting(): TargetingResponse | null {
-    const raw = this.storage.getItem(this.targetingV1Key);
-    const parsed = raw ? JSON.parse(raw) : null;
-    if (!parsed) {
-      return null;
-    }
-
-    const audiences = Object.entries(parsed).map(([keyspace, values]) => {
-      return {
-        provider: "optable.co",
-        keyspace,
-        // 5001 is Optable Private Member Defined Audiences
-        // See: https://github.com/InteractiveAdvertisingBureau/openrtb/pull/81
-        //
-        // Starting v2 this is returned in the targeting payload directly
-        rtb_segtax: 5001,
-        ids: [].concat(...[values as any]).map((id: any) => ({ id: String(id) })),
-      };
-    });
-
-    return {
-      user: [],
-      audience: audiences,
-    };
-  }
-
   getTargeting(): TargetingResponse | null {
     const raw = this.storage.getItem(this.targetingKey);
-    const parsed = raw ? JSON.parse(raw) : null;
-    return parsed ? parsed : this.getV1Targeting();
+    return raw ? JSON.parse(raw) : null;
   }
 
   setPassport(passport: string) {