Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split number property into longOrNull and doubleOrNull #196

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

OptimumCode
Copy link
Owner

Related to #191

@OptimumCode OptimumCode added enhancement New feature or request ABI breaking changes that break binary compatibility (does not mean they break API) API breaking changes that break API compatibility labels Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

PR introduces changes to the public API

Please add "ABI breaking" label if any line in API file was changed or deleted.
Please add "API breaking" label if any public method in API file was changed or deleted.

Generated by 🚫 Danger Kotlin against d67a084

@OptimumCode OptimumCode enabled auto-merge (squash) September 5, 2024 07:14
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.43%. Comparing base (2f973dd) to head (d67a084).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mcode/json/schema/internal/wrapper/JsonWrappers.kt 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   90.45%   90.43%   -0.02%     
==========================================
  Files         133      133              
  Lines        3907     3910       +3     
  Branches     1064     1063       -1     
==========================================
+ Hits         3534     3536       +2     
- Misses         76       77       +1     
  Partials      297      297              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'KMP JSON schema validator'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: d67a084 Previous: 2f973dd Ratio
macosX64.CommonThroughputBench.validateVerbose ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 108.13015369026009 ops/sec 70.91901577669888 ops/sec 1.52
macosX64.CommonThroughputBench.validate ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 330.2195440920236 ops/sec 205.85357827984112 ops/sec 1.60

This comment was automatically generated by workflow using github-action-benchmark.

CC: @OptimumCode

@OptimumCode OptimumCode merged commit 2cb7fdd into main Sep 5, 2024
21 checks passed
@OptimumCode OptimumCode deleted the update-model-api branch September 5, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI breaking changes that break binary compatibility (does not mean they break API) API breaking changes that break API compatibility enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant