Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReCaptchaLoginFilter #15736

Merged
merged 23 commits into from
Apr 18, 2024
Merged

Remove ReCaptchaLoginFilter #15736

merged 23 commits into from
Apr 18, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Apr 11, 2024

Fix #15702
Fix #12705

Beside fixing thee two referenced issues, here is a summary of improvements

  • We now honor IdentityOptions.User.RequireUniqueEmail where we did not in the past.
  • Removed the ReCaptchaLoginFilter and converted the following views to shapes
    • ForgotPassword.cshtml
    • Register.cshtml
    • ResetPassword.cshtml
  • Users can now reset their password using either a username or email address. In the past, only email address was allowed.

@MikeAlhayek MikeAlhayek requested a review from agriffard as a code owner April 11, 2024 23:09
@MikeAlhayek MikeAlhayek requested review from hishamco and removed request for agriffard April 13, 2024 19:04
@MikeAlhayek MikeAlhayek merged commit cd9f9f4 into main Apr 18, 2024
6 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/remove-recapcha-filter branch April 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ReCaptchaLoginFilter with drivers Reset Password bug
1 participant