From 9d0756801ee31bf4ea1a9723e60858990cc79ca6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Wed, 10 Apr 2024 16:07:59 +0200
Subject: [PATCH 01/10]  Treat warnings as errors during CI build

---
 .github/workflows/mac_unit_test_ci.yml | 2 +-
 .github/workflows/main_ci.yml          | 2 +-
 .github/workflows/pr_ci.yml            | 2 +-
 .github/workflows/preview_ci.yml       | 2 +-
 .github/workflows/release_ci.yml       | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/mac_unit_test_ci.yml b/.github/workflows/mac_unit_test_ci.yml
index cb5a8e63b21..7ba1d3f0574 100644
--- a/.github/workflows/mac_unit_test_ci.yml
+++ b/.github/workflows/mac_unit_test_ci.yml
@@ -13,5 +13,5 @@ jobs:
     - uses: actions/checkout@v3
     - name: Build and test
       run: |
-        dotnet build -c Release
+        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
         dotnet test -c Release --no-restore --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj
diff --git a/.github/workflows/main_ci.yml b/.github/workflows/main_ci.yml
index ca8bc847223..fa478440e54 100644
--- a/.github/workflows/main_ci.yml
+++ b/.github/workflows/main_ci.yml
@@ -27,7 +27,7 @@ jobs:
         dotnet-version: '8.0.x'
     - name: Build
       run: |
-        dotnet build -c Release
+        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj 
diff --git a/.github/workflows/pr_ci.yml b/.github/workflows/pr_ci.yml
index 7dcde8681af..418731c42c3 100644
--- a/.github/workflows/pr_ci.yml
+++ b/.github/workflows/pr_ci.yml
@@ -26,7 +26,7 @@ jobs:
         dotnet-version: '8.0.x'
     - name: Build
       run: |
-        dotnet build -c Release
+        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj
diff --git a/.github/workflows/preview_ci.yml b/.github/workflows/preview_ci.yml
index fe25acb75b8..c4219d197fa 100644
--- a/.github/workflows/preview_ci.yml
+++ b/.github/workflows/preview_ci.yml
@@ -35,7 +35,7 @@ jobs:
     - name: Build
       if: steps.check-publish.outputs.should-publish == 'true'
       run: |
-        dotnet build -c Release
+        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
     - name: Unit Tests
       if: steps.check-publish.outputs.should-publish == 'true'
       run: |
diff --git a/.github/workflows/release_ci.yml b/.github/workflows/release_ci.yml
index 3d3d1c312e3..19616b5a4a7 100644
--- a/.github/workflows/release_ci.yml
+++ b/.github/workflows/release_ci.yml
@@ -41,7 +41,7 @@ jobs:
       run: echo "BuildNumber=$(( $GITHUB_RUN_NUMBER + 15471 ))" >> $GITHUB_ENV
     - name: Build
       run: |
-        dotnet build -c Release -p:Version=${{ steps.get_version.outputs.VERSION }}
+        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True -p:Version=${{ steps.get_version.outputs.VERSION }}
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj 

From fdaeb7f3d1f6653dda7ac60e4a9d8657b7480ada Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Wed, 10 Apr 2024 16:26:32 +0200
Subject: [PATCH 02/10] Suppressing CA1016

---
 Directory.Build.props | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 235d562dc61..30002df456a 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -33,7 +33,7 @@
     <!-- Avoid using cref tags with a prefix -->
     <NoWarn>$(NoWarn);CA1200</NoWarn>
 
-    <!--Rename type name X so that it does not end in 'Delegate', 'EventHandler', 'Permission' etc -->
+    <!-- Rename type name X so that it does not end in 'Delegate', 'EventHandler', 'Permission' etc -->
     <NoWarn>$(NoWarn);CA1711</NoWarn>
 
     <!-- Parameter name differs from original overriden implemented name -->
@@ -54,9 +54,12 @@
     <!-- Use PascalCase for named placeholders in the logging message template -->
     <NoWarn>$(NoWarn);CA1727</NoWarn>
 
-    <!--CA1861 : Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array -->
+    <!-- CA1861: Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array -->
     <NoWarn>$(NoWarn);CA1861</NoWarn>
 
+    <!-- "CA1016: Mark assemblies with AssemblyVersionAttribute" is not needed since the Preview and Main CI builds add these. -->
+    <NoWarn>$(NoWarn);CA1016</NoWarn>
+
   </PropertyGroup>
 
 </Project>

From f2f5d56bd6baf0de5105f80ac16647f31786a6b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Mon, 15 Apr 2024 20:49:11 +0200
Subject: [PATCH 03/10] Disabling CA1016 only in OrchardCore.ProjectTemplates

---
 Directory.Build.props                                          | 3 ---
 .../OrchardCore.ProjectTemplates.csproj                        | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 30002df456a..735e9c009c9 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -57,9 +57,6 @@
     <!-- CA1861: Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array -->
     <NoWarn>$(NoWarn);CA1861</NoWarn>
 
-    <!-- "CA1016: Mark assemblies with AssemblyVersionAttribute" is not needed since the Preview and Main CI builds add these. -->
-    <NoWarn>$(NoWarn);CA1016</NoWarn>
-
   </PropertyGroup>
 
 </Project>
diff --git a/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj b/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj
index ba64f3403aa..8c7af6de538 100644
--- a/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj
+++ b/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj
@@ -24,7 +24,7 @@
       The error message is not accurate, as it indicates there is no content. It should say assemblies instead, since we have content but no assemblies.
         NU5128 warning: Ignore since the project template package doesn't contain content or references to other packages.
     -->
-    <NoWarn>CS8021,CS2008,NU5128</NoWarn>
+    <NoWarn>CS8021;CS2008;NU5128;CA1016</NoWarn>
     <!--
       Prevent the symbol package from being created as this nuget package doesn't have package refs or assemblies.
       Otherwise, the following error will be thrown by `dotnet pack`: error NU5017: Cannot create a package that has no dependencies nor content.

From b0c38a9909e8c5ca11454ccff6d1f58ded9121c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Mon, 15 Apr 2024 21:06:51 +0200
Subject: [PATCH 04/10] Safer build switches

---
 .github/workflows/mac_unit_test_ci.yml | 2 +-
 .github/workflows/main_ci.yml          | 2 +-
 .github/workflows/pr_ci.yml            | 2 +-
 .github/workflows/preview_ci.yml       | 2 +-
 .github/workflows/release_ci.yml       | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/mac_unit_test_ci.yml b/.github/workflows/mac_unit_test_ci.yml
index 5479b27b65c..6920f64f7a3 100644
--- a/.github/workflows/mac_unit_test_ci.yml
+++ b/.github/workflows/mac_unit_test_ci.yml
@@ -13,5 +13,5 @@ jobs:
     - uses: actions/checkout@v4
     - name: Build and test
       run: |
-        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
         dotnet test -c Release --no-restore --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj
diff --git a/.github/workflows/main_ci.yml b/.github/workflows/main_ci.yml
index 75f030064ee..52b5d6f27d1 100644
--- a/.github/workflows/main_ci.yml
+++ b/.github/workflows/main_ci.yml
@@ -27,7 +27,7 @@ jobs:
         dotnet-version: '8.0.x'
     - name: Build
       run: |
-        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj 
diff --git a/.github/workflows/pr_ci.yml b/.github/workflows/pr_ci.yml
index 59dea2c4022..3de9e9cd782 100644
--- a/.github/workflows/pr_ci.yml
+++ b/.github/workflows/pr_ci.yml
@@ -26,7 +26,7 @@ jobs:
         dotnet-version: '8.0.x'
     - name: Build
       run: |
-        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj
diff --git a/.github/workflows/preview_ci.yml b/.github/workflows/preview_ci.yml
index a066bf7d441..4e7ceb19102 100644
--- a/.github/workflows/preview_ci.yml
+++ b/.github/workflows/preview_ci.yml
@@ -35,7 +35,7 @@ jobs:
     - name: Build
       if: steps.check-publish.outputs.should-publish == 'true'
       run: |
-        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
     - name: Unit Tests
       if: steps.check-publish.outputs.should-publish == 'true'
       run: |
diff --git a/.github/workflows/release_ci.yml b/.github/workflows/release_ci.yml
index 3024b2aa4c1..ffc95c442ee 100644
--- a/.github/workflows/release_ci.yml
+++ b/.github/workflows/release_ci.yml
@@ -41,7 +41,7 @@ jobs:
       run: echo "BuildNumber=$(( $GITHUB_RUN_NUMBER + 15471 ))" >> $GITHUB_ENV
     - name: Build
       run: |
-        dotnet build -c Release --warnaserror -p:RunAnalyzersDuringBuild=True -p:Version=${{ steps.get_version.outputs.VERSION }}
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true -p:Version=${{ steps.get_version.outputs.VERSION }}
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj 

From 65d296d58719ccbe73e8edc2cbe1aae037bb28a6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Tue, 16 Apr 2024 00:52:04 +0200
Subject: [PATCH 05/10] Removing unnecessary <TreatWarningsAsErrors> elements
 from projects

---
 src/OrchardCore.Build/OrchardCore.Commons.props                  | 1 -
 src/OrchardCore.Cms.Web/OrchardCore.Cms.Web.csproj               | 1 -
 .../OrchardCore.ProjectTemplates.csproj                          | 1 -
 .../OrchardCore.Abstractions.Tests.csproj                        | 1 -
 .../OrchardCore.Application.Pages.csproj                         | 1 -
 test/OrchardCore.Tests/OrchardCore.Tests.csproj                  | 1 -
 6 files changed, 6 deletions(-)

diff --git a/src/OrchardCore.Build/OrchardCore.Commons.props b/src/OrchardCore.Build/OrchardCore.Commons.props
index 1ddaaab5712..68598319ed7 100644
--- a/src/OrchardCore.Build/OrchardCore.Commons.props
+++ b/src/OrchardCore.Build/OrchardCore.Commons.props
@@ -7,7 +7,6 @@
     <VersionPrefix>1.9.0</VersionPrefix>
     <VersionSuffix>preview</VersionSuffix>
     <VersionSuffix Condition="'$(VersionSuffix)'!='' AND '$(BuildNumber)' != ''">$(VersionSuffix)-$(BuildNumber)</VersionSuffix>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <WarningsNotAsErrors>612,618</WarningsNotAsErrors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <NoWarn>$(NoWarn);CS1591</NoWarn>
diff --git a/src/OrchardCore.Cms.Web/OrchardCore.Cms.Web.csproj b/src/OrchardCore.Cms.Web/OrchardCore.Cms.Web.csproj
index a5ac7fee774..8e43cc43852 100644
--- a/src/OrchardCore.Cms.Web/OrchardCore.Cms.Web.csproj
+++ b/src/OrchardCore.Cms.Web/OrchardCore.Cms.Web.csproj
@@ -7,7 +7,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(CommonTargetFrameworks)</TargetFrameworks>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <WarningsNotAsErrors>612,618</WarningsNotAsErrors>
     <AspNetCoreHostingModel>InProcess</AspNetCoreHostingModel>
     <RazorRuntimeCompilation>false</RazorRuntimeCompilation>
diff --git a/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj b/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj
index 8c7af6de538..b724dc147c1 100644
--- a/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj
+++ b/src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj
@@ -15,7 +15,6 @@
       This setting changes that so that the .template.config folder will be included.
     -->
     <NoDefaultExcludes>True</NoDefaultExcludes>
-    <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
     <PackageType>Template</PackageType>
     <!--
       The previous code used a nuget package to allow the 'RoslynCodeTaskFactory' (see the ReplaceFileText task definition below) to be used.
diff --git a/test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj b/test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj
index 7bcc8442f86..603e87fdff1 100644
--- a/test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj
+++ b/test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj
@@ -4,7 +4,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(CommonTargetFrameworks)</TargetFrameworks>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RootNamespace>OrchardCore</RootNamespace>
   </PropertyGroup>
 
diff --git a/test/OrchardCore.Tests.Pages/OrchardCore.Application.Pages/OrchardCore.Application.Pages.csproj b/test/OrchardCore.Tests.Pages/OrchardCore.Application.Pages/OrchardCore.Application.Pages.csproj
index a5287a6f720..ffdcd893df9 100644
--- a/test/OrchardCore.Tests.Pages/OrchardCore.Application.Pages/OrchardCore.Application.Pages.csproj
+++ b/test/OrchardCore.Tests.Pages/OrchardCore.Application.Pages/OrchardCore.Application.Pages.csproj
@@ -7,7 +7,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(CommonTargetFrameworks)</TargetFrameworks>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <AspNetCoreHostingModel>InProcess</AspNetCoreHostingModel>
     <RazorRuntimeCompilation>false</RazorRuntimeCompilation>
   </PropertyGroup>
diff --git a/test/OrchardCore.Tests/OrchardCore.Tests.csproj b/test/OrchardCore.Tests/OrchardCore.Tests.csproj
index 946db171578..a8a03143a2d 100644
--- a/test/OrchardCore.Tests/OrchardCore.Tests.csproj
+++ b/test/OrchardCore.Tests/OrchardCore.Tests.csproj
@@ -4,7 +4,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(CommonTargetFrameworks)</TargetFrameworks>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

From 6e049ca5e0e73d68fddc04d3df70d44e4dcb867c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Wed, 17 Apr 2024 17:42:15 +0200
Subject: [PATCH 06/10] Intentional analyzer violation to test CI build

---
 .../AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
index 7c42f547bdc..dd60a6ee1d8 100644
--- a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
+++ b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
@@ -110,7 +110,7 @@ public override async Task<IDisplayResult> DisplayAsync(AuditTrailEvent auditTra
             );
         }
 
-        private static void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
+        private void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
         {
             m.AuditTrailEvent = model;
             m.Descriptor = descriptor;

From a349f69bf0ff0c6ab617a7f3e0275a25f313874b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Wed, 17 Apr 2024 17:46:14 +0200
Subject: [PATCH 07/10] Revert "Intentional analyzer violation to test CI
 build"

This reverts commit 6e049ca5e0e73d68fddc04d3df70d44e4dcb867c.
---
 .../AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
index dd60a6ee1d8..7c42f547bdc 100644
--- a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
+++ b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
@@ -110,7 +110,7 @@ public override async Task<IDisplayResult> DisplayAsync(AuditTrailEvent auditTra
             );
         }
 
-        private void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
+        private static void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
         {
             m.AuditTrailEvent = model;
             m.Descriptor = descriptor;

From 3b2ce466875dcdb83a1a1e5f2ce6181308462fa3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Fri, 19 Apr 2024 02:27:52 +0200
Subject: [PATCH 08/10] Shorter build switch

---
 .github/workflows/mac_unit_test_ci.yml | 2 +-
 .github/workflows/main_ci.yml          | 2 +-
 .github/workflows/pr_ci.yml            | 2 +-
 .github/workflows/preview_ci.yml       | 2 +-
 .github/workflows/release_ci.yml       | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/mac_unit_test_ci.yml b/.github/workflows/mac_unit_test_ci.yml
index 6920f64f7a3..a915d0d2be5 100644
--- a/.github/workflows/mac_unit_test_ci.yml
+++ b/.github/workflows/mac_unit_test_ci.yml
@@ -13,5 +13,5 @@ jobs:
     - uses: actions/checkout@v4
     - name: Build and test
       run: |
-        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzers=true
         dotnet test -c Release --no-restore --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj
diff --git a/.github/workflows/main_ci.yml b/.github/workflows/main_ci.yml
index 52b5d6f27d1..0da6626d638 100644
--- a/.github/workflows/main_ci.yml
+++ b/.github/workflows/main_ci.yml
@@ -27,7 +27,7 @@ jobs:
         dotnet-version: '8.0.x'
     - name: Build
       run: |
-        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzers=true
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj 
diff --git a/.github/workflows/pr_ci.yml b/.github/workflows/pr_ci.yml
index 3de9e9cd782..4e645136ff5 100644
--- a/.github/workflows/pr_ci.yml
+++ b/.github/workflows/pr_ci.yml
@@ -26,7 +26,7 @@ jobs:
         dotnet-version: '8.0.x'
     - name: Build
       run: |
-        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzers=true
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj
diff --git a/.github/workflows/preview_ci.yml b/.github/workflows/preview_ci.yml
index 4e7ceb19102..cc7910525ef 100644
--- a/.github/workflows/preview_ci.yml
+++ b/.github/workflows/preview_ci.yml
@@ -35,7 +35,7 @@ jobs:
     - name: Build
       if: steps.check-publish.outputs.should-publish == 'true'
       run: |
-        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzers=true
     - name: Unit Tests
       if: steps.check-publish.outputs.should-publish == 'true'
       run: |
diff --git a/.github/workflows/release_ci.yml b/.github/workflows/release_ci.yml
index ffc95c442ee..6b9b440c45f 100644
--- a/.github/workflows/release_ci.yml
+++ b/.github/workflows/release_ci.yml
@@ -41,7 +41,7 @@ jobs:
       run: echo "BuildNumber=$(( $GITHUB_RUN_NUMBER + 15471 ))" >> $GITHUB_ENV
     - name: Build
       run: |
-        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true -p:Version=${{ steps.get_version.outputs.VERSION }}
+        dotnet build -c Release -warnaserror /p:TreatWarningsAsErrors=true /p:RunAnalyzers=true -p:Version=${{ steps.get_version.outputs.VERSION }}
     - name: Unit Tests
       run: |
         dotnet test -c Release --no-build ./test/OrchardCore.Tests/OrchardCore.Tests.csproj 

From 47ce4d8dc2a34a41fb4798ee93bf9350f663b488 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Fri, 19 Apr 2024 02:28:26 +0200
Subject: [PATCH 09/10] Intentional analyzer violation to test CI build

---
 .../AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
index 7c42f547bdc..dd60a6ee1d8 100644
--- a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
+++ b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
@@ -110,7 +110,7 @@ public override async Task<IDisplayResult> DisplayAsync(AuditTrailEvent auditTra
             );
         }
 
-        private static void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
+        private void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
         {
             m.AuditTrailEvent = model;
             m.Descriptor = descriptor;

From 0520ffcaef7e3d2e7feec2d9dd49d045a5442723 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= <zoltan.lehoczky@lombiq.com>
Date: Fri, 19 Apr 2024 02:32:15 +0200
Subject: [PATCH 10/10] Revert "Intentional analyzer violation to test CI
 build"

This reverts commit 47ce4d8dc2a34a41fb4798ee93bf9350f663b488.
---
 .../AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
index dd60a6ee1d8..7c42f547bdc 100644
--- a/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
+++ b/src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs
@@ -110,7 +110,7 @@ public override async Task<IDisplayResult> DisplayAsync(AuditTrailEvent auditTra
             );
         }
 
-        private void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
+        private static void BuildSummaryViewModel(AuditTrailContentEventViewModel m, AuditTrailEvent model, AuditTrailContentEvent contentEvent, AuditTrailEventDescriptor descriptor, string latestVersionId)
         {
             m.AuditTrailEvent = model;
             m.Descriptor = descriptor;