[Fix] 메뉴판 API 버그 수정 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit 629c2d8. ♻️ This comment has been updated with latest results. |
- 1분 -> 1시간
- request 추가
- 메뉴핀(3개) - 태그(오렌지, 화이트) - 폴더 아이콘(1개)
[Fix] Access token 기간
- 기타
You-Hyuk
approved these changes
Feb 5, 2025
| return UpdateMenuFolderResponse.of(menuFolder, menuMenuFolders); | ||
| } | ||
| if (isImageModified) { | ||
| //기존에 있는 이미지는 삭제한다 |
There was a problem hiding this comment.
주석 의도적으로 남기신 건가요?? 아니라면 삭제해주셔도 될 것 같습니당
There was a problem hiding this comment.
위 로직은 추후에 리펙토링 또는 코드 변경이 발생했을때, 기존 요구사항을 만족하면서 코드를 변경하기에는 이해하기 어려운 코드라고 생각합니다! 테스트 코드 작성 이전까지는 주석을 유지할게요
| menuFolder.updateImg(null); | ||
| } | ||
|
|
||
| //추가할 이미지가 있으면 추가한다 |
| @@ -10,6 +10,8 @@ | |||
| public class UpdateMenuFolderRequest { | |||
|
|
|||
| private MultipartFile menuFolderImg; | |||
| //@JsonProperty("isImageModified") | |||
[Feat] 캐시 이미지 조회
…OurMenu-BE-V2 into KAN-20-feat/menu-folder - 충돌 해결
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 작업 개요
⛳ 작업 분류
🔨 작업 상세 내용
💡 생각해볼 문제