Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prominence #302

Conversation

stepps00
Copy link
Contributor

@stepps00 stepps00 commented Dec 2, 2024

Category

What kind of change is this?
Please select one of the following four options.
Consult Pull request merging criteria for a description of each category.

  1. Cosmetic change.
  2. Documentation change by member.
  3. Documentation change by Overture tech writer.
  4. Material change.

Description

This fixes a portion of https://github.com/OvertureMaps/tf-admin/issues/82 and replaces #294.

This pull request adds a top-level prominence property to the cartographyContainer and necessary references to the divisions theme.

prominence: For the divisions theme, this field would represent Overture's view of a place's significance or importance. The min/max values are subject to change, but I've added 0 and 100 values for the property.

Reference

List of relevant links to GitHub issues, PRs, and other documentation.

Testing

Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.

TODO.

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

schema/defs.yaml Outdated Show resolved Hide resolved
@stepps00 stepps00 changed the title [WIP] Add prominence Add prominence Dec 5, 2024
jonahadkins
jonahadkins previously approved these changes Dec 5, 2024
sasastanojkov
sasastanojkov previously approved these changes Dec 6, 2024
DavidKarlas
DavidKarlas previously approved these changes Dec 9, 2024
@stepps00
Copy link
Contributor Author

stepps00 commented Dec 9, 2024

cc @vcschapp / @TristanDiet-TomTom for sign off on the series of divisions schema changes.

@jenningsanderson jenningsanderson changed the base branch from dev to prominence-divisions-from-stepps00 December 12, 2024 22:34
@jenningsanderson jenningsanderson merged commit 5351c2d into prominence-divisions-from-stepps00 Dec 12, 2024
1 of 2 checks passed
@jenningsanderson
Copy link
Collaborator

See #308

@jenningsanderson jenningsanderson deleted the stepps00/prominence-divisions branch December 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants