-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prominence #302
Merged
jenningsanderson
merged 5 commits into
prominence-divisions-from-stepps00
from
stepps00/prominence-divisions
Dec 12, 2024
Merged
Add prominence #302
jenningsanderson
merged 5 commits into
prominence-divisions-from-stepps00
from
stepps00/prominence-divisions
Dec 12, 2024
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcschapp
reviewed
Dec 4, 2024
jonahadkins
previously approved these changes
Dec 5, 2024
sasastanojkov
previously approved these changes
Dec 6, 2024
DavidKarlas
previously approved these changes
Dec 9, 2024
cc @vcschapp / @TristanDiet-TomTom for sign off on the series of divisions schema changes. |
vcschapp
dismissed stale reviews from DavidKarlas, sasastanojkov, and jonahadkins
via
December 11, 2024 16:31
3f9f890
DavidKarlas
approved these changes
Dec 11, 2024
TristanDiet-TomTom
approved these changes
Dec 11, 2024
jenningsanderson
changed the base branch from
dev
to
prominence-divisions-from-stepps00
December 12, 2024 22:34
jenningsanderson
merged commit Dec 12, 2024
5351c2d
into
prominence-divisions-from-stepps00
1 of 2 checks passed
See #308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
What kind of change is this?
Please select one of the following four options.
Consult Pull request merging criteria for a description of each category.
Description
This fixes a portion of https://github.com/OvertureMaps/tf-admin/issues/82 and replaces #294.
This pull request adds a top-level
prominence
property to the cartographyContainer and necessary references to the divisions theme.prominence
: For the divisions theme, this field would represent Overture's view of a place's significance or importance. The min/max values are subject to change, but I've added0
and100
values for the property.Reference
List of relevant links to GitHub issues, PRs, and other documentation.
Testing
Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.
TODO.
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.