-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMIP5 and 6 comparing portrait and parallel coordinate plot #843
Conversation
NOTE: Need to update to use |
Add taylor diagram
add init file
@acordonez I think this PR is ready for review, could you verify notebooks are working well on your end too when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted my prior comment and reposting as a review - The notebooks worked for me. One thing I noticed is that I had some old files in my portrait_plot/json_files that hadn't downloaded correctly in a past test (contained 404 errors). This caused a failure in the portrait plot notebook until I removed the existing json_files folder and started from scratch. Would the notebook still give the correct results if users had old versions of the same data in json_files? Should the json_files be cleaned before running each time?
@acordonez thank you for checking. I have assumed that user will run from scratch -- starting from downloading, but I see your point -- thanks for pointing it out. I might have to implement more elegant way of downloading, but I think that is for the next PR unless we find any quick solution. |
Jupyter notebooks for creation of portrait and parallel coordinate plots for comparing CMIP5 and CMIP6 models.