Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean clim obs info dict update #880

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Oct 19, 2022

No description provided.

@lee1043 lee1043 added the bug label Oct 19, 2022
@lee1043 lee1043 added this to the 2.5.1 milestone Oct 19, 2022
@lee1043 lee1043 requested a review from acordonez October 19, 2022 01:24
@lee1043 lee1043 self-assigned this Oct 19, 2022
@lee1043 lee1043 linked an issue Oct 19, 2022 that may be closed by this pull request
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a test run with hfss, hus, and hur. The hfss part worked for all regions, but I'm getting the following error for hus and hur, with all regions:

INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: VAR: hus, REGION: global
INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: reference_data_set (given): ['all'], reference_data_set_is_obs: True, test_data_set_is_obs: False
INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: reference_data_set (adjusted): ['default'], test_data_set: ['E3SM-1-0']
INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: default is an obs
INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: Could not figure out obs mask name from obs json file
INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: TEST DATA IS: E3SM-1-0
INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: E3SM-1-0 is a model
INFO::2022-10-19 11:16::pcmdi_metrics::E3SM:: Unexpected error in calculate output metrics: Only length-1 arrays can be converted to Python scalars

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 19, 2022

@acordonez thank you for checking it. I found I have got same errors for hur and hus, which I don't have a good idea for the cause.

@gleckler1 Have you seen this error before?

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 19, 2022

@acordonez I think I've got some clue. The error message for hus and hur is caused by treating them like spatial 2d variable, while they actually are spatial 3d variables with level.

I tested hus_850 and hur_850 and they worked for me. Can you try that on your end and see if that works for you?

@acordonez
Copy link
Collaborator

@lee1043 Yes that worked for me! Thank you.

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 20, 2022

@acordonez Excellent, thank you for checking on that.

@lee1043 lee1043 merged commit 2127ac2 into main Oct 20, 2022
@lee1043 lee1043 deleted the mean_clim_obs_info_dict_update branch October 20, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mean climate "no reference dataset" error
2 participants