Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sbml model enhancements #333

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

fbergmann
Copy link
Collaborator

This PR allows to create SBML models from string, but more critically considers an SBML model with warnings still as valid SbmlModel. The current PEtab implementation considers a file with warnings as invalid SBML, which is not the case.

@fbergmann fbergmann requested a review from a team as a code owner December 5, 2024 14:22
@fbergmann fbergmann requested a review from dweindl December 5, 2024 14:22
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.86%. Comparing base (9a4efb4) to head (195f534).

Files with missing lines Patch % Lines
petab/v1/models/sbml_model.py 33.33% 4 Missing ⚠️
petab/v1/sbml.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
- Coverage    74.92%   74.86%   -0.07%     
===========================================
  Files           52       52              
  Lines         4913     4921       +8     
  Branches       845      847       +2     
===========================================
+ Hits          3681     3684       +3     
- Misses         923      928       +5     
  Partials       309      309              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl merged commit d3e4006 into PEtab-dev:develop Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants