Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add displayBlankAs propery to Chart #581

Closed
wants to merge 6 commits into from

Conversation

TonisOrmisson
Copy link
Contributor

add displayBlankAs to Chart to define how missing/blank values are displayed on chart.

Also includes tests...

@auto-assign auto-assign bot requested a review from Progi1984 June 13, 2020 18:57
@TonisOrmisson TonisOrmisson changed the title add displayBlankAs to Chart add displayBlankAs propery to Chart Jun 13, 2020
@TonisOrmisson
Copy link
Contributor Author

The travis tests failing seem to be mostly memory issues not related to this PR changes.
The php 7.3 failure seems weird since the same code passes in my branch tests:
https://travis-ci.com/github/TonisOrmisson/PHPPresentation/builds/171224924

@Progi1984
Copy link
Member

@TonisOrmisson Good news. I have integrated your contribution in code 💪 with support in Writer ODPresentation/Powerpoint2007. Check the PR #659

@Progi1984 Progi1984 closed this Jul 26, 2021
@Progi1984 Progi1984 added this to the 1.0.0 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants