Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for axis options (Intersection Point & Reverse Axis) in PowerPoint2007 Writer #676

Merged
merged 7 commits into from
Dec 7, 2021
Merged

Support for axis options (Intersection Point & Reverse Axis) in PowerPoint2007 Writer #676

merged 7 commits into from
Dec 7, 2021

Conversation

mindline-analytics
Copy link
Contributor

  • adds crosses/ crossesAt options to axis component
  • adds reversed order to axis component

@auto-assign auto-assign bot requested a review from Progi1984 August 30, 2021 15:02
@mindline-analytics
Copy link
Contributor Author

Hi @Progi1984, any feedback/ change requests on this PR?

Progi1984
Progi1984 reviewed Nov 25, 2021
View reviewed changes
Progi1984
Progi1984 reviewed Nov 26, 2021
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mindline-analytics Good job. Could you rebase your PR and fix my suggestions ?

After that, I will test in my local environment and I will merge it if it's OK.

Thanks again for your contribution.

@Progi1984 Progi1984 added this to the Waiting For Answer milestone Nov 26, 2021
@mindline-analytics
Copy link
Contributor Author

Hi @Progi1984, welcome back :)
I have made the requested changes. I hope Saturday's github outage caused the failing tests.

@Progi1984 Progi1984 changed the title Feat axis options Support for axis options (Intersection Point & Reverse Axis) in PowerPoint2007 Writer Dec 7, 2021
@Progi1984 Progi1984 modified the milestones: Waiting For Answer, 1.1.0 Dec 7, 2021
@Progi1984 Progi1984 merged commit f5907e1 into PHPOffice:develop Dec 7, 2021
@Progi1984
Copy link
Member

Thanks @mindline-analytics

@mindline-analytics mindline-analytics deleted the feat-axis-options branch December 7, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 left review comments

Assignees

@Progi1984 Progi1984

Labels
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mindline-analytics @Progi1984