Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Group support for PowerPoint2007. #68

Merged
merged 9 commits into from
Dec 22, 2014
Merged

Adding Group support for PowerPoint2007. #68

merged 9 commits into from
Dec 22, 2014

Conversation

joshuadoss
Copy link
Contributor

Changes include:

  1. Adding the ability to group shapes together on a slide.
  2. Adds (or corrects, depending on perspective) extent and offset calculation on slides.
  3. Unit test for new Group object.
  4. New sample (09) to generate PowerPoint with grouped objects.
  5. Change to CHANGELOG.md.

@Progi1984
Copy link
Member

Hi @pr0phet, could you :

Thanks for this great PR.

@joshuadoss
Copy link
Contributor Author

Thanks @Progi1984. ODP will take a few days.

@Progi1984
Copy link
Member

@pr0phet No, Thanks to you for this big PR. I will wait for your ODT improvement.

Fixed bug wherein grouped pics weren't included in the pptx.
Fixed bug wherein hyperlinks within groups were not functional
@joshuadoss
Copy link
Contributor Author

@Progi1984 I think I hit the same issue that you hit a few months back. That's the only thing that I can see is wrong with the PHP 5.3.3 build of the code. I tried to see what you did to fix your issue in Chart.php, but it appears you didn't do anything to the code to make the issue go away... Any input would be appreciated.

@Progi1984
Copy link
Member

@pr0phet Could you pull the last version of the develop branch and commit it ? I could merge this one after.

Conflicts resolved:
	src/PhpPowerpoint/Writer/PowerPoint2007/Rels.php
@Progi1984 Progi1984 added this to the 0.3.0 milestone Dec 22, 2014
Progi1984 added a commit that referenced this pull request Dec 22, 2014
Adding Group support for PowerPoint2007.
@Progi1984 Progi1984 merged commit b9be2aa into PHPOffice:develop Dec 22, 2014
Progi1984 added a commit that referenced this pull request Dec 22, 2014
Progi1984 added a commit that referenced this pull request Dec 22, 2014
@Progi1984 Progi1984 modified the milestones: 0.3.0, 0.4.0 Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants