Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treatment of weights in Records object constructor, Part 2 #1440

Closed
martinholmer opened this issue Jun 27, 2017 · 1 comment
Closed

Treatment of weights in Records object constructor, Part 2 #1440

martinholmer opened this issue Jun 27, 2017 · 1 comment

Comments

@martinholmer
Copy link
Collaborator

Pull request #844, which was merged on August 10, 2016, included the following code in the Records class constructor:

        # weights must be same size as tax record data
        if not self.WT.empty and self.dim != len(self.WT):
            frac = float(self.dim) / len(self.WT)
            self.WT = self.WT.iloc[self.index]
            self.WT = self.WT / frac

The calculation of frac has already been discussed in issue #1439.

An additional problem with the above code is that it ignores the fact that the weights vary from year to year, and therefore, applying one value of frac to weights in all the years creates unnecessary variation in sample weights across years.

@MattHJensen @feenberg @hdoupe

@martinholmer
Copy link
Collaborator Author

Issue #1440 has been resolved by the merge of pull request #1441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant