Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Behavior parameter validation logic #1556

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Improve Behavior parameter validation logic #1556

merged 3 commits into from
Sep 21, 2017

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Sep 20, 2017

This pull request strengthens the parameter validation logic in the Behavior class, particularly when the Behavior constructor is supplied a dictionary (instead of the usual procedure of reading the default parameters and their values from the behavior.json file).

Note: this pull request extends the changes made in #1554.

@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun

@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #1556 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1556   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2603    2644   +41     
======================================
+ Hits         2603    2644   +41
Impacted Files Coverage Δ
taxcalc/parameters.py 100% <100%> (ø) ⬆️
taxcalc/behavior.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd70f49...dc43069. Read the comment docs.

@martinholmer martinholmer merged commit 2f755a1 into PSLmodels:master Sep 21, 2017
@martinholmer martinholmer deleted the fix-behavior branch September 21, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants