Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing files change for V4 #2752

Merged
merged 15 commits into from
Jun 3, 2024
Merged

testing files change for V4 #2752

merged 15 commits into from
Jun 3, 2024

Conversation

bodiyang
Copy link
Contributor

@bodiyang bodiyang commented May 28, 2024

This PR is part of the effort to merge V4_development branch into master branch.

V4_development GitActions tests fail, on a single test to compare a local reform file and an online url file.

This PR makes necessary changes (changing the online url file) to help V4_development branch pass its online tests.

This PR will make V4_development branch pass all GitActions tests (but will make the master branch fail its online tests, for now). Our final goal is to merge V4_development branch into master branch. After the merge, master branch will have all tests pass.

@bodiyang
Copy link
Contributor Author

@jdebacker after merge this PR, the V4_development branch tests are expected to pass

@martinholmer
Copy link
Collaborator

I don't understand what this is doing.
@bodiyang, please resolve your test failures on you local computer.

@jdebacker jdebacker reopened this May 30, 2024
@jdebacker
Copy link
Member

@bodiyang Can you provide a more detailed description in the first comment in this thread?

@martinholmer We are preparing for a version 4.0 release. In the v4_development branch, only a single test fails and that is one that runs a test on a reform read from a URL (test_policy.py::test_json_reform_url). @bodiyang is modifying the reform called by that test in this PR (which will be merged with checks failing - they fail because the master branch does not have separate employer and employee side payroll tax parameters as the v4_development branch does). Once these changes are merged into master, we can open a PR merging v4_development -> master and all checks will pass.

@martinholmer
Copy link
Collaborator

@jdebacker said:

We are preparing for a version 4.0 release. In the v4_development branch, only a single test fails and that is one that runs a test on a reform read from a URL (test_policy.py::test_json_reform_url). @bodiyang is modifying the reform called by that test in this PR (which will be merged with checks failing - they fail because the master branch does not have separate employer and employee side payroll tax parameters as the v4_development branch does). Once these changes are merged into master, we can open a PR merging v4_development -> master and all checks will pass.

Why was there no explanation of this in the P|R?

@bodiyang
Copy link
Contributor Author

@martinholmer Please see my first comment for the goal of this PR.

@jdebacker I think this PR is ready to merge, which will help V4_development branch have all tests pass.

@jdebacker jdebacker merged commit 079fdfd into PSLmodels:master Jun 3, 2024
1 of 7 checks passed
@jdebacker
Copy link
Member

Thanks for these changes, @bodiyang. Merging.

bodiyang added a commit to bodiyang/Tax-Calculator that referenced this pull request Jun 4, 2024
Merge pull request PSLmodels#2752 from bodiyang/master
@jdebacker jdebacker mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants