From fc028d7725fa2142fe2c71637fe0f2ff9f831e9a Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Mon, 3 Jun 2024 15:40:38 +0200 Subject: [PATCH 1/5] Disable JSCPD linting --- .github/workflows/workflow.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index 26fdde82..bdc6047c 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -529,6 +529,7 @@ jobs: GITHUB_TOKEN: ${{ github.token }} RUN_LOCAL: true VALIDATE_ALL_CODEBASE: false + VALIDATE_JSCPD: false PublishModule: name: Publish module From d7eb5c529a22307b1b8c9e46df37234455a50d21 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Mon, 3 Jun 2024 15:44:01 +0200 Subject: [PATCH 2/5] Remove -Verbose switches --- tests/src/finally.ps1 | 6 +++--- tests/src/init/initializer.ps1 | 6 +++--- tests/src/scripts/loader.ps1 | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/src/finally.ps1 b/tests/src/finally.ps1 index e51c2260..d8fc2071 100644 --- a/tests/src/finally.ps1 +++ b/tests/src/finally.ps1 @@ -1,3 +1,3 @@ -Write-Verbose '------------------------------' -Verbose -Write-Verbose '--- THIS IS A LAST LOADER ---' -Verbose -Write-Verbose '------------------------------' -Verbose +Write-Verbose '------------------------------' +Write-Verbose '--- THIS IS A LAST LOADER ---' +Write-Verbose '------------------------------' diff --git a/tests/src/init/initializer.ps1 b/tests/src/init/initializer.ps1 index f4121d25..28396fb0 100644 --- a/tests/src/init/initializer.ps1 +++ b/tests/src/init/initializer.ps1 @@ -1,3 +1,3 @@ -Write-Verbose '-------------------------------' -Verbose -Write-Verbose '--- THIS IS AN INITIALIZER ---' -Verbose -Write-Verbose '-------------------------------' -Verbose +Write-Verbose '-------------------------------' +Write-Verbose '--- THIS IS AN INITIALIZER ---' +Write-Verbose '-------------------------------' diff --git a/tests/src/scripts/loader.ps1 b/tests/src/scripts/loader.ps1 index 29ad42f6..973735ad 100644 --- a/tests/src/scripts/loader.ps1 +++ b/tests/src/scripts/loader.ps1 @@ -1,3 +1,3 @@ -Write-Verbose '-------------------------' -Verbose -Write-Verbose '--- THIS IS A LOADER ---' -Verbose -Write-Verbose '-------------------------' -Verbose +Write-Verbose '-------------------------' +Write-Verbose '--- THIS IS A LOADER ---' +Write-Verbose '-------------------------' From c8bb13d59309716ce09aa3db3aa8157a798f95c8 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Mon, 3 Jun 2024 15:44:35 +0200 Subject: [PATCH 3/5] Fix --- tests/src/modules/OtherPSModule.psm1 | 2 +- tests/src/private/Get-InternalPSModule.ps1 | 2 +- tests/src/private/Set-InternalPSModule.ps1 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/src/modules/OtherPSModule.psm1 b/tests/src/modules/OtherPSModule.psm1 index 9e4353ba..5d6af8ea 100644 --- a/tests/src/modules/OtherPSModule.psm1 +++ b/tests/src/modules/OtherPSModule.psm1 @@ -1,4 +1,4 @@ -Function Get-OtherPSModule { +function Get-OtherPSModule { <# .SYNOPSIS Performs tests on a module. diff --git a/tests/src/private/Get-InternalPSModule.ps1 b/tests/src/private/Get-InternalPSModule.ps1 index 3366e44b..89f053cb 100644 --- a/tests/src/private/Get-InternalPSModule.ps1 +++ b/tests/src/private/Get-InternalPSModule.ps1 @@ -1,4 +1,4 @@ -Function Get-InternalPSModule { +function Get-InternalPSModule { <# .SYNOPSIS Performs tests on a module. diff --git a/tests/src/private/Set-InternalPSModule.ps1 b/tests/src/private/Set-InternalPSModule.ps1 index 11c2fa15..cf870ba6 100644 --- a/tests/src/private/Set-InternalPSModule.ps1 +++ b/tests/src/private/Set-InternalPSModule.ps1 @@ -1,4 +1,4 @@ -Function Set-InternalPSModule { +function Set-InternalPSModule { <# .SYNOPSIS Performs tests on a module. From 42779ac35fd9350ad42b5c9f7a8afe2890c8777d Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Mon, 3 Jun 2024 15:55:18 +0200 Subject: [PATCH 4/5] Fix --- tests/srcWithManifest/finally.ps1 | 6 +++--- tests/srcWithManifest/init/initializer.ps1 | 6 +++--- tests/srcWithManifest/modules/OtherPSModule.psm1 | 2 +- tests/srcWithManifest/private/Get-InternalPSModule.ps1 | 2 +- tests/srcWithManifest/private/Set-InternalPSModule.ps1 | 2 +- tests/srcWithManifest/scripts/loader.ps1 | 6 +++--- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/srcWithManifest/finally.ps1 b/tests/srcWithManifest/finally.ps1 index e51c2260..d8fc2071 100644 --- a/tests/srcWithManifest/finally.ps1 +++ b/tests/srcWithManifest/finally.ps1 @@ -1,3 +1,3 @@ -Write-Verbose '------------------------------' -Verbose -Write-Verbose '--- THIS IS A LAST LOADER ---' -Verbose -Write-Verbose '------------------------------' -Verbose +Write-Verbose '------------------------------' +Write-Verbose '--- THIS IS A LAST LOADER ---' +Write-Verbose '------------------------------' diff --git a/tests/srcWithManifest/init/initializer.ps1 b/tests/srcWithManifest/init/initializer.ps1 index f4121d25..28396fb0 100644 --- a/tests/srcWithManifest/init/initializer.ps1 +++ b/tests/srcWithManifest/init/initializer.ps1 @@ -1,3 +1,3 @@ -Write-Verbose '-------------------------------' -Verbose -Write-Verbose '--- THIS IS AN INITIALIZER ---' -Verbose -Write-Verbose '-------------------------------' -Verbose +Write-Verbose '-------------------------------' +Write-Verbose '--- THIS IS AN INITIALIZER ---' +Write-Verbose '-------------------------------' diff --git a/tests/srcWithManifest/modules/OtherPSModule.psm1 b/tests/srcWithManifest/modules/OtherPSModule.psm1 index 9e4353ba..5d6af8ea 100644 --- a/tests/srcWithManifest/modules/OtherPSModule.psm1 +++ b/tests/srcWithManifest/modules/OtherPSModule.psm1 @@ -1,4 +1,4 @@ -Function Get-OtherPSModule { +function Get-OtherPSModule { <# .SYNOPSIS Performs tests on a module. diff --git a/tests/srcWithManifest/private/Get-InternalPSModule.ps1 b/tests/srcWithManifest/private/Get-InternalPSModule.ps1 index 3366e44b..89f053cb 100644 --- a/tests/srcWithManifest/private/Get-InternalPSModule.ps1 +++ b/tests/srcWithManifest/private/Get-InternalPSModule.ps1 @@ -1,4 +1,4 @@ -Function Get-InternalPSModule { +function Get-InternalPSModule { <# .SYNOPSIS Performs tests on a module. diff --git a/tests/srcWithManifest/private/Set-InternalPSModule.ps1 b/tests/srcWithManifest/private/Set-InternalPSModule.ps1 index 11c2fa15..cf870ba6 100644 --- a/tests/srcWithManifest/private/Set-InternalPSModule.ps1 +++ b/tests/srcWithManifest/private/Set-InternalPSModule.ps1 @@ -1,4 +1,4 @@ -Function Set-InternalPSModule { +function Set-InternalPSModule { <# .SYNOPSIS Performs tests on a module. diff --git a/tests/srcWithManifest/scripts/loader.ps1 b/tests/srcWithManifest/scripts/loader.ps1 index 29ad42f6..973735ad 100644 --- a/tests/srcWithManifest/scripts/loader.ps1 +++ b/tests/srcWithManifest/scripts/loader.ps1 @@ -1,3 +1,3 @@ -Write-Verbose '-------------------------' -Verbose -Write-Verbose '--- THIS IS A LOADER ---' -Verbose -Write-Verbose '-------------------------' -Verbose +Write-Verbose '-------------------------' +Write-Verbose '--- THIS IS A LOADER ---' +Write-Verbose '-------------------------' From fee55293201fe4dbf5b3027dc6fa7ffeb12381b8 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Mon, 3 Jun 2024 16:00:58 +0200 Subject: [PATCH 5/5] disable JSCPD on this repo --- .github/workflows/Linter.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Linter.yml b/.github/workflows/Linter.yml index 5c9f300c..52daecd5 100644 --- a/.github/workflows/Linter.yml +++ b/.github/workflows/Linter.yml @@ -27,3 +27,4 @@ jobs: uses: super-linter/super-linter@latest env: GITHUB_TOKEN: ${{ github.token }} + VALIDATE_JSCPD: false