add licenses for binary/image #73
Conversation
| FROM bitnami/minideb:stretch | ||
| WORKDIR / | ||
| COPY --from=builder /workspace/manager . | ||
| COPY third_party/licenses/licenses.csv /workspace/licenses.csv |
There was a problem hiding this comment.
Note, you need to call go-licenses save to save the actual full text licenses into the image.
Use https://github.com/kubeflow/pipelines/blob/e58aff78f67b32d0ee2125b2678abf0c3fa4073a/v2/container/launcher/Dockerfile#L36-L37 as an example.
There was a problem hiding this comment.
thanks to your help. I've fix it.
| github.com/cespare/xxhash/v2, https://github.com/cespare/xxhash/blob/v2.1.1/LICENSE.txt, MIT | ||
| github.com/coreos/go-semver, https://github.com/coreos/go-semver/blob/v0.3.0/LICENSE, Apache-2.0 | ||
| github.com/coreos/go-systemd/v22, https://github.com/coreos/go-systemd/blob/v22.3.2/LICENSE, Apache-2.0 | ||
| github.com/davecgh/go-spew, https://github.com/davecgh/go-spew/blob/v1.1.1/LICENSE, ISC |
There was a problem hiding this comment.
There are too many entries for go-spew, gogo/protobuf, ...
They are false positives detected by the tool, because these repos have a license header on every file.
In these cases, you should override for these modules in go-licenses.yaml. I believe a lot of libraries you use are also KFP dependencies, so you can use what I prepare for KFP as an easy reference: https://github.com/kubeflow/pipelines/blob/master/v2/go-licenses.yaml.
generate licenses for golang binary and add it to image