Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dy2Stat]Support non-tensor type in input_spec #33464

Merged
merged 6 commits into from
Jun 17, 2021
Merged

[Dy2Stat]Support non-tensor type in input_spec #33464

merged 6 commits into from
Jun 17, 2021

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Jun 9, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

[Dy2Stat]Support non-tensor type in input_spec

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 9, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

TCChenlong
TCChenlong previously approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CtfGo
Copy link
Contributor

CtfGo commented Jun 16, 2021

LGTM

chenwhql
chenwhql reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/fluid/dygraph/dygraph_to_static/utils.py Outdated Show resolved Hide resolved
python/paddle/fluid/dygraph/dygraph_to_static/utils.py Outdated Show resolved Hide resolved
hbwx24
hbwx24 previously approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@hbwx24 hbwx24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hbwx24
hbwx24 reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@hbwx24 hbwx24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 dismissed stale reviews from hbwx24 and TCChenlong via 71efa40 June 16, 2021 10:38
@Aurelius84 Aurelius84 merged commit 63b03cf into PaddlePaddle:develop Jun 17, 2021
2742195759 pushed a commit to 2742195759/Paddle that referenced this pull request Jul 26, 2021
@Aurelius84 @2742195759
[Dy2Stat]Support non-tensor type in input_spec (PaddlePaddle#33464)
b67e027 
* support non-tensor type

* fix unittest failed

* add unittest with prune

* rm unused code

* coverage

* fix two or
lanxianghit pushed a commit that referenced this pull request Jul 26, 2021
@2742195759
[cherry-pick][Dy2Stat]Support non-tensor type in input_spec (#33464) #…
9b48cfd 
…34378

[Dy2Stat]Support non-tensor type in input_spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@zhhsplendid zhhsplendid Awaiting requested review from zhhsplendid

@liym27 liym27 Awaiting requested review from liym27

@hbwx24 hbwx24 Awaiting requested review from hbwx24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aurelius84 @CtfGo @TCChenlong @hbwx24 @chenwhql