add new API/OP: paddle.linalg.triangular_solve #36714

zhwesky2010 · 2021-10-25T15:41:41Z

PR types

New features

PR changes

APIs

Describe

Computes the solution of a system of equations with a triangular coefficient matrix x and
multiple right-hand sides y .

Input x and y is 2D matrices or batches of 2D matrices. If the inputs are batches, the outputs
is also batches.

Args:

x (Tensor): The input triangular coefficient matrix. Its shape should be [*, M, M], where * is zero or
    more batch dimensions. Its data type should be float32 or float64.
y (Tensor): Multiple right-hand sides of system of equations. Its shape should be [*, M, K], where * is 
    zero or more batch dimensions. Its data type should be float32 or float64.
upper (bool, optional): Whether to solve the upper-triangular system of equations (default) or the lower-triangular 
    system of equations. Default: True.
transpose (bool, optional): whether x should be transposed before calculation. Default: False.
unitriangular (bool, optional): whether x is unit triangular. If True, the diagonal elements of x are assumed 
    to be 1 and not referenced from x . Default: False.
name(str, optional): Name for the operation (optional, default is None).

Returns:

Tensor: The solution of the system of equations. Its data type should be the same as that of `x`.

Examples:

# A · X = b
#
# a square system of linear equations:
# x1 +   x2  +   x3 = 0
#      2*x2  +   x3 = -9
#               -x3 = 5

import paddle

x = paddle.to_tensor([[1, 1, 1], 
                      [0, 2, 1],
                      [0, 0,-1]], dtype="float64")
y = paddle.to_tensor([[0], [-9], [5]], dtype="float64")
out = paddle.linalg.triangular_solve(x, y, upper=True, transpose=False, unitriangular=False)

print(out)
# [7, -2, -5]

paddle-bot-old · 2021-10-25T15:41:44Z

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

… develop

Avin0323

LGTM for PR-CI-OP-benchmark.

jeff41404 · 2021-10-28T07:52:54Z

paddle/fluid/operators/math/matrix_solve.cc

+    int M = b->dims()[b_dim_size - 2];
+    int N = b->dims()[b_dim_size - 1];


Tensor->dims()[] wll return int64_t, use static_cast ?

jeff41404 · 2021-10-28T07:53:25Z

paddle/fluid/operators/math/matrix_solve.cu.cc

+    int M = b->dims()[b_dim_size - 2];
+    int N = b->dims()[b_dim_size - 1];


Tensor->dims()[] wll return int64_t, use static_cast ?

jeff41404

lgtm

TCChenlong

LGTM

jzhang533 · 2021-10-28T10:27:52Z

python/paddle/tensor/linalg.py

+        #               -x3 = 5
+
+        import paddle
+        import numpy as np


numpy没用到。

下个PR顺带删掉~ thx

XiaoguangHu01

LG API

jzhang533

LGTM

raindrops2sea

LGTM

* add new API: paddle.linalg.triangular_solve * add new API/OP: paddle.linalg.triangular_solve * add new API/OP: paddle.linalg.triangular_solve * fix comment

ignore test_triangular_solve.py because PaddlePaddle/Paddle#36714 havn't cherry-pick yet.

* add new API: paddle.linalg.triangular_solve * add new API/OP: paddle.linalg.triangular_solve * add new API/OP: paddle.linalg.triangular_solve * fix comment

cherry-pick #36714

zhwesky2010 added 2 commits October 25, 2021 15:42

add new API: paddle.linalg.triangular_solve

835a84d

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

6657903

… develop

zhwesky2010 force-pushed the triangular_solve branch from 558addd to 2a783a8 Compare October 25, 2021 19:54

zhwesky2010 force-pushed the triangular_solve branch from 2a783a8 to d62922e Compare October 25, 2021 20:04

zhwesky2010 force-pushed the triangular_solve branch from d62922e to 0930b77 Compare October 25, 2021 20:13

zhwesky2010 changed the title ~~add new API/OP: paddle.linalg.triangular_solve~~ add new API/OP: paddle.linalg.triangular_solve Oct 25, 2021

zhwesky2010 force-pushed the triangular_solve branch from 0930b77 to 62c533c Compare October 25, 2021 20:23

add new API/OP: paddle.linalg.triangular_solve

032d66c

zhwesky2010 force-pushed the triangular_solve branch from 62c533c to 39eb297 Compare October 27, 2021 17:29

zhwesky2010 force-pushed the triangular_solve branch from 39eb297 to ef7e4b1 Compare October 27, 2021 18:01

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

2c24183

… develop

zhwesky2010 force-pushed the triangular_solve branch from ef7e4b1 to 2c24183 Compare October 27, 2021 18:04

add new API/OP: paddle.linalg.triangular_solve

b312dcb

zhwesky2010 force-pushed the triangular_solve branch from 7ade8de to b312dcb Compare October 28, 2021 04:34

zhwesky2010 requested review from jeff41404, XiaoguangHu01, raindrops2sea, jzhang533 and TCChenlong October 28, 2021 05:33

Avin0323 previously approved these changes Oct 28, 2021

View reviewed changes

jeff41404 reviewed Oct 28, 2021

View reviewed changes

fix comment

339ac8f

zhwesky2010 dismissed Avin0323’s stale review via 339ac8f October 28, 2021 08:20

jeff41404 approved these changes Oct 28, 2021

View reviewed changes

TCChenlong approved these changes Oct 28, 2021

View reviewed changes

jzhang533 reviewed Oct 28, 2021

View reviewed changes

XiaoguangHu01 approved these changes Oct 28, 2021

View reviewed changes

jzhang533 approved these changes Oct 28, 2021

View reviewed changes

raindrops2sea approved these changes Oct 29, 2021

View reviewed changes

zhwesky2010 merged commit 92d6a04 into PaddlePaddle:develop Oct 29, 2021

DDDivano added a commit to PaddlePaddle/PaddleTest that referenced this pull request Nov 24, 2021

Update run.sh

b1377a9

ignore test_triangular_solve.py because PaddlePaddle/Paddle#36714 havn't cherry-pick yet.

zhwesky2010 mentioned this pull request Nov 25, 2021

[cherry-pick2.2]add new API/OP: paddle.linalg.triangular_solve #37551

Merged

lanxianghit pushed a commit that referenced this pull request Nov 26, 2021

add new API/OP: paddle.linalg.triangular_solve (#36714) (#37551)

3a81805

cherry-pick #36714

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add new API/OP: paddle.linalg.triangular_solve #36714

add new API/OP: paddle.linalg.triangular_solve #36714

zhwesky2010 commented Oct 25, 2021 •

edited

Loading

paddle-bot-old bot commented Oct 25, 2021

Avin0323 left a comment

jeff41404 Oct 28, 2021

zhwesky2010 Oct 28, 2021

jeff41404 Oct 28, 2021

zhwesky2010 Oct 28, 2021

jeff41404 left a comment

TCChenlong left a comment

jzhang533 Oct 28, 2021

zhwesky2010 Oct 28, 2021 •

edited

Loading

XiaoguangHu01 left a comment

jzhang533 left a comment

raindrops2sea left a comment

		int M = b->dims()[b_dim_size - 2];
		int N = b->dims()[b_dim_size - 1];

add new API/OP: paddle.linalg.triangular_solve #36714

add new API/OP: paddle.linalg.triangular_solve #36714

Conversation

zhwesky2010 commented Oct 25, 2021 • edited Loading

PR types

PR changes

Describe

paddle-bot-old bot commented Oct 25, 2021

Avin0323 left a comment

Choose a reason for hiding this comment

jeff41404 Oct 28, 2021

Choose a reason for hiding this comment

zhwesky2010 Oct 28, 2021

Choose a reason for hiding this comment

jeff41404 Oct 28, 2021

Choose a reason for hiding this comment

zhwesky2010 Oct 28, 2021

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

TCChenlong left a comment

Choose a reason for hiding this comment

jzhang533 Oct 28, 2021

Choose a reason for hiding this comment

zhwesky2010 Oct 28, 2021 • edited Loading

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

jzhang533 left a comment

Choose a reason for hiding this comment

raindrops2sea left a comment

Choose a reason for hiding this comment

zhwesky2010 commented Oct 25, 2021 •

edited

Loading

zhwesky2010 Oct 28, 2021 •

edited

Loading