fix bug to support dropout eval grad computing. #37305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dX.device(place) = static_cast<T>(0) * dY; | ||
| if (is_test) { | ||
| if (dropout_implementation == "upscale_in_train") { | ||
| dX.device(place) = static_cast<T>(1) * dY; |
There was a problem hiding this comment.
嗯嗯，该pr只用于恢复 #35122 的修改哈。后续可以进一步优化。
limin2021
added a commit
to limin2021/Paddle
that referenced
this pull request
Nov 18, 2021
* fix bug to support dropout eval grad computing. * Remove useless code.
lanxianghit
pushed a commit
that referenced
this pull request
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Question:
#35122 support dropout in eval mode (paddle2.0已经将eval和no_grad解绑，eval下做反向是合理的，竞品也都支持这个行为). But #35621 remove these modifications of #35122.
In this PR, we recover the modifications in #35122.
test code:
before this PR:
after this PR:
