Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lml/add prim ops #41201

Merged
merged 96 commits into from
Apr 13, 2022
Merged

Lml/add prim ops #41201

merged 96 commits into from
Apr 13, 2022

Conversation

levi131
Copy link
Contributor

@levi131 levi131 commented Mar 31, 2022 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

Add autograd primitive ops for new autograd mechanism, and some unit tests.
18 autograd primitive ops are added:

    reshape_p_op
    broadcast_p_op
    reduce_p_op
    transpose_p_op
    split_p_op
    concat_p_op
    slice_select_p_op
    slice_assign_p_op
    gather_p_op
    scatter_add_p_op
    add_p_op
    sub_p_op
    mul_p_op
    div_p_op
    sqrt_p_op
    tanh_p_op
    matmul_p_op
    fill_constant_p_op

veyron95 and others added 30 commits September 22, 2021 04:09
@veyron95
native commit for triple grad of sigmod
80b884e
@veyron95
Updated unittests files
d52b81c
init functional jacobian api
19d6b05
merge upstream/develop
f47b48f
@JiabinYang
Merge pull request #2 from veyron95/ops_derivative
16c048a 
native commit for triple grad of sigmod
@JiabinYang
Merge branch 'support_derivative' of https://github.com/JiabinYang/Pa…
a6a9053 
…ddle into support_derivative
@veyron95
Updated trible_test func
4febae7
@veyron95
Updated gradient_checker & test_script
be9da74
finish test with dtype float32
be2b30d
add float64 test case
36b8c34
polish code
35b1ce8
use atol=1e-5 with dtype float64
3a35a00
fix for ci
a3ea12e
set timeout for test_jacobian
8738cf8
@JiabinYang
fix dygraph grad to support high differential
d6e771e
polish API docstring
0bd8287
@veyron95
Merge branch 'support_derivative' of https://github.com/JiabinYang/Pa…
83c8395 
…ddle into ops_derivative
@veyron95
Updated gradient checker and some related files
4109fc5
@JiabinYang
Merge pull request #4 from veyron95/ops_derivative
19e471c 
Ops derivative
@JiabinYang
Merge branch 'lml/jacobian' of https://github.com/levi131/Paddle into…
1573b2c 
… support_derivative
@JiabinYang
fix double grad strip error for high differential
1408ef5
@JiabinYang
fix double grad strip error for high differential
ea78b6e
@veyron95
Add Sigmoid triple grad tests
2351a99
@JiabinYang
fix dygraph double grad dtype error when calling for high differentia…
7a3fbd1 
…l senario
@JiabinYang
Merge pull request #8 from veyron95/ops_derivative
42df611 
Add Sigmoid triple grad tests
@veyron95
Updated triple grad teses func
a6dde75
@veyron95
Use np.random to initialize ddx
848efcf
@veyron95
Updated triple_grad_check func
04eab89
@JiabinYang
Merge pull request #9 from veyron95/ops_derivative
38ca20a 
Updated triple grad teses func
@JiabinYang
merge develop
886d9fb
thisjiang
thisjiang reviewed Apr 13, 2022
View reviewed changes
paddle/fluid/operators/prim_ops/add_p_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/prim_ops/broadcast_p_op.cc Show resolved Hide resolved
paddle/fluid/operators/prim_ops/concat_p_op.cc Show resolved Hide resolved
paddle/fluid/operators/prim_ops/concat_p_op.cc Show resolved Hide resolved
paddle/fluid/operators/prim_ops/div_p_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/prim_ops/slice_select_p_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/prim_ops/split_p_op.cc Show resolved Hide resolved
paddle/fluid/operators/prim_ops/split_p_op.cc Show resolved Hide resolved
paddle/fluid/operators/prim_ops/sub_p_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/prim_ops/transpose_p_op.cc Show resolved Hide resolved
thisjiang
thisjiang approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tongxin
tongxin reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@tongxin tongxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

XiaoguangHu01
XiaoguangHu01 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levi131 levi131 merged commit 97dec7c into PaddlePaddle:develop Apr 13, 2022
@levi131 levi131 mentioned this pull request May 14, 2022
Merged
@pangyoki pangyoki mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongxin tongxin tongxin left review comments

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@thisjiang thisjiang thisjiang approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees

@tongxin tongxin

@XiaoguangHu01 XiaoguangHu01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@levi131 @tongxin @wanghuancoder @thisjiang @XiaoguangHu01 @veyron95 @JiabinYang