【Hackathon No.56 57 58 59】sparse elementwise add sub mul div #41857

gsq7474741 · 2022-04-15T10:19:58Z

PR types

New features

PR changes

OPs

Describe

add paddle.incubate.sparse.add subtract multiply divide and c++ kernels
This PR is an entry point of Hackathon task No.56 57 58 59
Tasks:

Related work:

Docs: 【Hackathon2 No.56 57 58 59 Hackathon3 No.23】add doc of paddle.incubate.sparse.add subtract multiply divide is_same_shape docs#4705
RFCs: fix typo and design of sparse rfc community#95
RFCs: 【Hackathon No.56 57 58 59】Fix sparse elementwise api RFCs community#123

reset author

# Conflicts: # python/paddle/sparse/__init__.py

paddle-bot-old · 2022-04-15T10:22:43Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/phi/kernels/sparse/cpu/sparse_elementwise_kernel.cc

gsq7474741 · 2022-06-17T08:31:29Z

你好，yaml形式规范可以参考下这个PR，合并到一起在设计上更好：https://github.com/PaddlePaddle/Paddle/pull/42935/files#diff-bfad6f19739eb95b60bd46fc6a77adbf3ccb4a5ebac465b7aba845ae15470f11

好的，已参考该设计修改

zhwesky2010 · 2022-06-17T10:17:39Z

你好，经过内部讨论，目前形成以下一些sparse开发规范要求：

1.【yaml规则】：写到同一个yaml api，不要写多个
2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr
3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致

辛苦对kenrel注册名、与文件名进行修改

gsq7474741 · 2022-06-17T11:17:58Z

你好，经过内部讨论，目前达成以下一些sparse开发规范要求：

1.【yaml规则】：写到同一个yaml api，不要写多个，yaml需支持调度 2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr 3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致

辛苦对kenrel注册名、与文件名进行修改

加减乘除要写成四个文件么

zhwesky2010 · 2022-06-17T11:42:32Z

你好，经过内部讨论，目前达成以下一些sparse开发规范要求：
1.【yaml规则】：写到同一个yaml api，不要写多个，yaml需支持调度 2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr 3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致
辛苦对kenrel注册名、与文件名进行修改

加减乘除要写成四个文件么

就写到sparse/elementwise_kernel.h/cc/cu吧，文件不用sparse前缀，使用目录区分

gsq7474741 · 2022-06-17T13:50:27Z

你好，经过内部讨论，目前达成以下一些sparse开发规范要求：

1.【yaml规则】：写到同一个yaml api，不要写多个，yaml需支持调度 2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr 3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致

辛苦对kenrel注册名、与文件名进行修改

加减乘除要写成四个文件么

这里复用比较多，就合到elementwise_kernel.h/cc/cu吧，不用sparse前缀

指的是dense的这个文件么

zhwesky2010 · 2022-06-17T14:37:20Z

就写到sparse/elementwise_kernel.h/cc/cu里吧，文件不用sparse前缀，使用目录区分

python/paddle/utils/code_gen/sparse_api.yaml

python/paddle/utils/code_gen/sparse_bw_api.yaml

zkh2016

LGTM

TCChenlong

LGTM

XiaoguangHu01

LGTM

…addle#41857)

zhwesky2010 · 2022-10-24T08:21:23Z

@gsq7474741 你好，这个kernel在FLAGS_use_system_allocator=0时单测是正确的，在FLAGS_use_system_allocator=1时会发生错误，kernel可能有地址访问bug需要修复。

gsq7474741 and others added 8 commits April 10, 2022 13:17

add sparse elementwise

1cd85c3

Merge remote-tracking branch 'origin/develop' into add_sparse_add

8b853ca

add sparse elementwise v0.2

524f257

Merge remote-tracking branch 'origin/develop' into add_sparse_add

53cd020

add sparse elementwise v0.3

dffed88

reset author

add sparse elementwise v0.3

2b55850

Merge remote-tracking branch 'origin/develop' into add_sparse_add

775c759

# Conflicts: # python/paddle/sparse/__init__.py

add sparse elementwise v0.3

ef85476

gsq7474741 mentioned this pull request Apr 15, 2022

【PFCC】使用python调用api时对c++后端debug的问题 #41827

Closed

paddle-bot-old bot added contributor External developers status: proposed labels Apr 15, 2022

gsq7474741 mentioned this pull request Apr 15, 2022

【PaddlePaddle Hackathon 第二期】任务总览 #40234

Closed

add sparse elementwise v0.5

4b0a795

gsq7474741 changed the title ~~[WIP] exit code 139 (interrupted by signal 11: SIGSEGV) when add sparse op~~ 【Hackathon No.56 57 58 59】 Apr 16, 2022

gsq7474741 added 4 commits April 16, 2022 17:23

add sparse elementwise v0.5

23405df

add sparse elementwise v0.5

91113f0

add sparse elementwise v0.5

7fafe60

Merge remote-tracking branch 'origin/develop' into add_sparse_add

c505424

gsq7474741 added 2 commits April 18, 2022 01:18

add sparse elementwise v0.7

8295c6c

add sparse elementwise v0.7

c0a1715

gsq7474741 force-pushed the add_sparse_add branch from 529bf91 to c0a1715 Compare April 17, 2022 17:27

zkh2016 reviewed Apr 18, 2022

View reviewed changes

paddle/phi/kernels/sparse/cpu/sparse_elementwise_kernel.cc Outdated Show resolved Hide resolved

gsq7474741 dismissed stale reviews from TCChenlong and zkh2016 via 2be0b15 June 15, 2022 10:08

gsq7474741 added 8 commits June 15, 2022 18:17

kernel and api name change

6528899

kernel and api name change

8061189

kernel and api name change

d7fc195

kernel and api name change

5eda983

kernel and api name change

359465f

kernel and api name change

f7332b5

kernel and api name change

9dfcbf1

kernel and api name change

6fec8a9

gsq7474741 requested a review from zkh2016 June 16, 2022 08:12

kernel and api name change

581f0e2

zhwesky2010 reviewed Jun 21, 2022

View reviewed changes

python/paddle/utils/code_gen/sparse_api.yaml Outdated Show resolved Hide resolved

python/paddle/utils/code_gen/sparse_bw_api.yaml Outdated Show resolved Hide resolved

fix kernel name

89d8cc5

zhwesky2010 approved these changes Jun 23, 2022 •

edited

Loading

View reviewed changes

zkh2016 approved these changes Jun 23, 2022

View reviewed changes

TCChenlong approved these changes Jun 23, 2022

View reviewed changes

chenwhql approved these changes Jun 23, 2022

View reviewed changes

XiaoguangHu01 approved these changes Jun 23, 2022

View reviewed changes

zkh2016 merged commit e3d94fc into PaddlePaddle:develop Jun 23, 2022

sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022

【Hackathon No.56 57 58 59】sparse elementwise add sub mul div (PaddleP…

52447dc

…addle#41857)

gsq7474741 mentioned this pull request Sep 4, 2022

【Hackathon2 No.56 57 58 59 Hackathon3 No.23】add doc of paddle.incubate.sparse.add subtract multiply divide is_same_shape PaddlePaddle/docs#4705

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon No.56 57 58 59】sparse elementwise add sub mul div #41857

【Hackathon No.56 57 58 59】sparse elementwise add sub mul div #41857

gsq7474741 commented Apr 15, 2022 •

edited by zhwesky2010

Loading

paddle-bot-old bot commented Apr 15, 2022

gsq7474741 commented Jun 17, 2022

zhwesky2010 commented Jun 17, 2022 •

edited

Loading

gsq7474741 commented Jun 17, 2022

zhwesky2010 commented Jun 17, 2022 •

edited

Loading

gsq7474741 commented Jun 17, 2022

zhwesky2010 commented Jun 17, 2022 •

edited

Loading

zkh2016 left a comment

TCChenlong left a comment

XiaoguangHu01 left a comment

zhwesky2010 commented Oct 24, 2022 •

edited

Loading

【Hackathon No.56 57 58 59】sparse elementwise add sub mul div #41857

【Hackathon No.56 57 58 59】sparse elementwise add sub mul div #41857

Conversation

gsq7474741 commented Apr 15, 2022 • edited by zhwesky2010 Loading

PR types

PR changes

Describe

paddle-bot-old bot commented Apr 15, 2022

gsq7474741 commented Jun 17, 2022

zhwesky2010 commented Jun 17, 2022 • edited Loading

gsq7474741 commented Jun 17, 2022

zhwesky2010 commented Jun 17, 2022 • edited Loading

gsq7474741 commented Jun 17, 2022

zhwesky2010 commented Jun 17, 2022 • edited Loading

zkh2016 left a comment

Choose a reason for hiding this comment

TCChenlong left a comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

zhwesky2010 commented Oct 24, 2022 • edited Loading

gsq7474741 commented Apr 15, 2022 •

edited by zhwesky2010

Loading

zhwesky2010 commented Jun 17, 2022 •

edited

Loading

zhwesky2010 commented Jun 17, 2022 •

edited

Loading

zhwesky2010 commented Jun 17, 2022 •

edited

Loading

zhwesky2010 commented Oct 24, 2022 •

edited

Loading