Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature of paddle audio #45424

Merged
merged 49 commits into from
Sep 8, 2022
Merged

add feature of paddle audio #45424

merged 49 commits into from
Sep 8, 2022

Conversation

SmileGoat
Copy link
Contributor

@SmileGoat SmileGoat commented Aug 25, 2022 •
edited
Loading

PR types

New features

PR changes

others

Describe

add feature&dataset of paddle audio

@paddle-bot
Copy link

paddle-bot bot commented Aug 25, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Aug 25, 2022 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@SmileGoat SmileGoat changed the title add feature&dataset of paddle audio add feature of paddle audio Aug 28, 2022
zh794390558
zh794390558 previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZeyuChen
ZeyuChen requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测流程是否可以走运行时的方式直接对比结果，而不是直接将之前dump好的tensor进行比对。
这样可以固定下来我们测试对应的librosa的语音库的版本。

python/paddle/audio/__init__.py Outdated Show resolved Hide resolved
python/paddle/tests/testdata/audio.txt Outdated Show resolved Hide resolved
ZeyuChen
ZeyuChen requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要将这些testdata的npy文件直接commit进代码库，会增大库体积。这些走运行时的方式在执行单测时动态生成。

@ZeyuChen ZeyuChen self-assigned this Aug 29, 2022
zh794390558
zh794390558 previously approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZeyuChen
ZeyuChen reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

检查下关键对外暴露的类是否有完备的单测覆盖，至少覆盖多种可选的参数

python/paddle/audio/compliance/librosa.py Outdated Show resolved Hide resolved
python/paddle/audio/compliance/librosa.py Outdated Show resolved Hide resolved
python/paddle/audio/features/layers.py Show resolved Hide resolved
python/paddle/audio/features/layers.py Show resolved Hide resolved
ZeyuChen
ZeyuChen previously approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 previously approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZeyuChen
ZeyuChen approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen merged commit 7c1dc75 into PaddlePaddle:develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 left review comments

@zh794390558 zh794390558 zh794390558 left review comments

Assignees

@ZeyuChen ZeyuChen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SmileGoat @ZeyuChen @zh794390558 @XiaoguangHu01