Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build strategy #46531

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Fix build strategy #46531

merged 2 commits into from
Oct 14, 2022

Conversation

Wong4j
Copy link
Collaborator

@Wong4j Wong4j commented Sep 27, 2022

PR types

Bug fixes

PR changes

Others

Describe

In v2.3.0 release, debug_graphviz_path and fuse_gemm_epilogue can not be enabled with the following way. Because build_strategy that are not in distributed_strategy.proto will be discarded in dist_strategy.build_strategy.

build_strategy.fuse_gemm_epilogue = True
build_strategy.debug_graphviz_path = './graph'
dist_strategy.build_strategy = build_strategy
...

To fix: Add them to distributed_strategy.proto.

@paddle-bot
Copy link

paddle-bot bot commented Sep 27, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 27, 2022
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2022

CLA assistant check
All committers have signed the CLA.

@jeng1220
Copy link
Collaborator

jeng1220 commented Oct 13, 2022

I saw 2022-09-27 13:37:43 Bus error during build in PR-CI-Coverage

@sneaxiy
Copy link
Collaborator

sneaxiy commented Oct 13, 2022

Hi, @Wong4j , please sign the CLA to pass the license/cla CI.

@Wong4j
Copy link
Collaborator Author

Wong4j commented Oct 13, 2022

Hi, @Wong4j , please sign the CLA to pass the license/cla CI.

Done

@sneaxiy sneaxiy merged commit fcdc677 into PaddlePaddle:develop Oct 14, 2022
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
zlsh80826 pushed a commit to zlsh80826/Paddle that referenced this pull request Nov 23, 2022
qingqing01 pushed a commit that referenced this pull request Nov 28, 2022
* Reduce squeeze2_matmul_fuse_pass, flattent tests time (#47098)

* Add missing fp32 config and reduce the testing combination

* Reduce trt matmul pass test max examples

* Loose TRT fp16 tests tolerance (#47100)

* Loose TRT half test tolerance to 1e-3 (#47101)

* Loose TRT half test tolerance to 1e-3 (#47106)

* Update distributed_strategy.proto (#46531)

* Close popen pipe after used (#47053)

* Add launch_bounds (#47285)

* Fix TRT UT failures (#47488)

* Format cherry-picked commits

* CudnnNormConvolution is no longer supported on NVIDIA Hopper GPUs (#48203)

* Skip tests that use fused_ops on H100

* Add error message to FusedOps on H100

Co-authored-by: Shijie <505749828@qq.com>
Co-authored-by: Leo Chen <39020268+leo0519@users.noreply.github.com>
Co-authored-by: Tian Zheng <tizheng@nvidia.com>
@Wong4j Wong4j deleted the fix_build_strategy branch February 14, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants