-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to_dlpack #50138
Merged
Merged
Fix to_dlpack #50138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
Closed
ZHUI
reviewed
Feb 1, 2023
@@ -475,20 +475,14 @@ void BindTensor(pybind11::module &m) { // NOLINT | |||
[](phi::DenseTensor &self) { | |||
DLPackTensor dlpack_tensor(self, 1); | |||
DLManagedTensor *dmt = dlpack_tensor.ToDLManagedTensor(); | |||
auto capsule = py::capsule( | |||
auto capsule = pybind11::capsule( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr 内容栏补充一下 问题原因,修复策略吧
luotao1
approved these changes
Feb 6, 2023
heliqi
approved these changes
Feb 6, 2023
DesmonDay
added a commit
that referenced
this pull request
Feb 6, 2023
* fix to_dlpack for loop * fix reference count
This was referenced Feb 6, 2023
jzhang533
pushed a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe