Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 4th 】add Trapezoid API && add Cumulative_trapezoid API #51195

Merged
merged 42 commits into from
Mar 28, 2023
Merged

【Hackathon 4th 】add Trapezoid API && add Cumulative_trapezoid API #51195

merged 42 commits into from
Mar 28, 2023

Conversation

Ainavo
Copy link
Contributor

@Ainavo Ainavo commented Mar 4, 2023 •
edited
Loading

@paddle-bot
Copy link

paddle-bot bot commented Mar 4, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 4, 2023
@Ainavo Ainavo changed the title [WIP]【Hackathon No.3】add Trapezoid API [WIP]【Hackathon 4th 】add Trapezoid API && add Cumulative_trapezoid API Mar 5, 2023
@Ainavo Ainavo mentioned this pull request Mar 5, 2023
Closed
@Ainavo Ainavo changed the title [WIP]【Hackathon 4th 】add Trapezoid API && add Cumulative_trapezoid API 【Hackathon 4th 】add Trapezoid API && add Cumulative_trapezoid API Mar 7, 2023
@Ainavo Ainavo mentioned this pull request Mar 7, 2023
Merged
@Ligoml Ligoml mentioned this pull request Mar 7, 2023
Closed
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 9, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 9, 2023
@luotao1 luotao1 added the API label Mar 10, 2023
@luotao1
Copy link
Contributor

luotao1 commented Mar 10, 2023

2023-03-10 04:38:33 In addition, mistakes found in sample codes: samplecode_temp/paddle.Tensor.cumulative_trapezoid_example.py
2023-03-10 04:38:33 1 sample codes ran success
2023-03-10 04:38:33 1 sample codes ran failed
2023-03-10 04:38:33 samplecode_temp/paddle.Tensor.cumulative_trapezoid_example.py

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 10, 2023

2023-03-10 04:38:33 In addition, mistakes found in sample codes: samplecode_temp/paddle.Tensor.cumulative_trapezoid_example.py 2023-03-10 04:38:33 1 sample codes ran success 2023-03-10 04:38:33 1 sample codes ran failed 2023-03-10 04:38:33 samplecode_temp/paddle.Tensor.cumulative_trapezoid_example.py

示例代码看起来好像没什么错误，本地跑的时候也没有报错，只有在gpu环境下给了warnings😂😂😂

@luotao1
Copy link
Contributor

luotao1 commented Mar 16, 2023

在paddle.diff API的静态图分支中，为类型检查增加float16类型即可。

@Ainavo 可以单独提个PR来解决这个问题

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 16, 2023

在paddle.diff API的静态图分支中，为类型检查增加float16类型即可。

@Ainavo 可以单独提个PR来解决这个问题

好的

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 19, 2023

image
paddle_build CI 一直会报错 No rule to make target.. 的错误，可以请 @luotao1 看一下是什么问题吗？

@luotao1
Copy link
Contributor

luotao1 commented Mar 20, 2023 •
edited
Loading

paddle_build CI 一直会报错 No rule to make target.. 的错误

先整理下我碰到的相似问题：都是二次改单测，然后编译过不了

  1. 本PR在 8a6ac3e paddle-build流水线能通过

8a23b4d59f6d662e2a8a0976dda97093

后续 commit 只是更新了单测文件以及文档，就编译过不了了。

image

  1. https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/8030936/job/22111674
    image

  2. 【PaddlePaddle Hackathon 4 NO.23】为 Paddle 新增 vander API #51048 (comment)

@luotao1 luotao1 mentioned this pull request Mar 20, 2023
Merged
@SigureMo
Copy link
Member

paddle_build CI 一直会报错 No rule to make target.. 的错误

我这边有同样的问题 #51693，看起来可能是只要是加新的单测就能稳定复现此问题

@SigureMo SigureMo mentioned this pull request Mar 21, 2023
Merged
9 tasks
@luotao1
Copy link
Contributor

luotao1 commented Mar 21, 2023

@Ainavo @SigureMo @Li-fAngyU paddle-build失败的问题已修复，可以rerun一下

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 22, 2023

CI已过，辛苦 @jeff41404 review 一下

jeff41404
jeff41404 previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 reviewed Mar 24, 2023
View reviewed changes
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
sunzhongkai588
sunzhongkai588 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit cfe3ff4 into PaddlePaddle:develop Mar 28, 2023
@Ainavo Ainavo deleted the api_for_trapezoid branch March 28, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@jeff41404 jeff41404 jeff41404 left review comments

Assignees

@luotao1 luotao1

@jeff41404 jeff41404

@Ligoml Ligoml

Labels
API contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Ainavo @luotao1 @zhangting2020 @SigureMo @jeff41404 @sunzhongkai588 @Ligoml