Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StandaloneExe] Remove flag about Executor #52671

Merged
merged 14 commits into from
Apr 10, 2023
Merged

[StandaloneExe] Remove flag about Executor #52671

merged 14 commits into from
Apr 10, 2023

Conversation

kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Apr 8, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

This PR deletes the following flags, which are used to decide whether use StandaloneExecutor or not in different scenes:

  1. FLAGS_control_flow_use_new_executor
  2. FLAGS_DY2ST_USE_STANDALONE_EXECUTOR
  3. FLAGS_CUDA_GRAPH_USE_STANDALONE_EXECUTOR

This PR also renames the new strategy introduced in #52652 from force_sequential_run to sequentail_run.

Other

Pcard-67004

@paddle-bot
Copy link

paddle-bot bot commented Apr 8, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhiqiu
zhiqiu previously approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangguangli kangguangli changed the title [StandaloneExe] Remove flag [StandaloneExe] Remove flag about Executor Apr 9, 2023
zhiqiu
zhiqiu approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangguangli kangguangli merged commit d6ee0a1 into PaddlePaddle:develop Apr 10, 2023
@kangguangli kangguangli deleted the remove_flag branch May 19, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanxianghit lanxianghit lanxianghit approved these changes

@phlrain phlrain phlrain approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kangguangli @zhiqiu @phlrain @lanxianghit