[Zero-Dim] Support output 0D for to_tensor. #52741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Apr 19, 2023
| @@ -58,6 +59,8 @@ def _apply_collective_grads(parameters, comm_group, bucket_size, scale=None): | |||
| for coalesced_grad, _, _ in coalesced_grads_and_vars: | |||
| # need to div nranks | |||
| if scale is not None: | |||
| if np.isscalar(scale) and not isinstance(scale, str): | |||
There was a problem hiding this comment.
elementwise_div应该已经支持了除以0D，这个保持原来的写法后面代码会挂不
There was a problem hiding this comment.
这个可以保持原来的写法。
| @@ -117,7 +117,7 @@ def recv_meta(self, group): | |||
|
|
|||
| def _send_dims_shape_dtype(self, tensor, group): | |||
| # send len(shape) | |||
| dims = paddle.to_tensor(len(tensor.shape)) | |||
| dims = paddle.to_tensor([len(tensor.shape)]) | |||
There was a problem hiding this comment.
这个如果保持原来的写法，1D变0D后面会出错吗
zhwesky2010
previously approved these changes
Apr 19, 2023
dingjiaweiww
previously approved these changes
Apr 21, 2023
zhengqiwen1997
dismissed stale reviews from XiaoguangHu01, dingjiaweiww, and zhwesky2010
via
d329327
zhengqiwen1997
changed the title
Ligoml
approved these changes
Apr 24, 2023
lijialin03
pushed a commit
to lijialin03/Paddle
that referenced
this pull request
Apr 25, 2023
* test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * test=allcase * fix doc erros, test=allcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
pcard-66984
支持API输出0D Tensor：to_tensor。